Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: tools/valgrind/common.py

Issue 8688006: Set up python BROWSER_WRAPPER for ui_tests under Dr. Memory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/valgrind/common.py
===================================================================
--- tools/valgrind/common.py (revision 111527)
+++ tools/valgrind/common.py (working copy)
@@ -162,7 +162,7 @@
# Don't show our testing framework:
("testing::Test::Run", "_ZN7testing4Test3RunEv"),
("testing::TestInfo::Run", "_ZN7testing8TestInfo3RunEv"),
- ("testing::internal::Handle*ExceptionsInMethodIfSupported",
+ ("testing::internal::Handle*ExceptionsInMethodIfSupported*",
Timur Iskhodzhanov 2011/11/24 15:01:14 Dr. Memory prints out the <...> template list whic
"_ZN7testing8internal3?Handle*ExceptionsInMethodIfSupported*"),
# Depend on scheduling:
@@ -212,3 +212,26 @@
return out.strip()
else:
return path
+
+############################
+# Common output format code
+
+def PrintUsedSuppressionsList(suppcounts):
Timur Iskhodzhanov 2011/11/24 15:01:14 TODO: re-use this for Valgrind and TSan and HeapCh
+ """ Prints out the list of used suppressions in a format common to all the
+ memory tools. If the list is empty, prints nothing and returns False,
+ otherwise True.
+
+ suppcounts: a dictionary of used suppression counts,
+ Key -> name, Value -> count.
+ """
+ if not suppcounts:
+ return False
+
+ print "-----------------------------------------------------"
+ print "Suppressions used:"
+ print " count name"
+ for (name, count) in sorted(suppcounts.items(), key=lambda (k,v): (v,k)):
+ print "%7d %s" % (count, name)
+ print "-----------------------------------------------------"
+ sys.stdout.flush()
+ return True

Powered by Google App Engine
This is Rietveld 408576698