Set up python BROWSER_WRAPPER for ui_tests under Dr. Memory

Set up python BROWSER_WRAPPER for ui_tests under Dr. Memory

Also, clean-up and slightly re-design drmemory_analyze.py to be more like
memcheck_analyze.py
Looks like more refactoring can be done later to really share the code with
Valgrind and TSan, esp. the BROWSER_WRAPPER itself.
No idea why it was a bash script initially.

TBR=bruening,glider
TEST=ran tools\valgrind\chrome_tests.bat --tool drmemory_light --keep_logs -t base --gtest_filter="*Sanity*"
     and ... -t ui --gtest_filter="RedirectTest.Server:RedirectTest.Client"
     with tools/valgrind/drmemory/suppressions.txt removed
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111528

[Timur Iskhodzhanov, 2011-11-24 15:01:14]

TBR

http://codereview.chromium.org/8688006/diff/2001/tools/valgrind/common.py
File tools/valgrind/common.py (right):

http://codereview.chromium.org/8688006/diff/2001/tools/valgrind/common.py#new...
tools/valgrind/common.py:165:
("testing::internal::Handle*ExceptionsInMethodIfSupported*",
Dr. Memory prints out the <...> template list which is ommited by TSan => wasn't
matching.

http://codereview.chromium.org/8688006/diff/2001/tools/valgrind/common.py#new...
tools/valgrind/common.py:219: def PrintUsedSuppressionsList(suppcounts):
TODO: re-use this for Valgrind and TSan and HeapCheck.
They use the same format, but at the cost of code duplication.

This will be a follow-up CL.

http://codereview.chromium.org/8688006/diff/2001/tools/valgrind/drmemory_anal...
File tools/valgrind/drmemory_analyze.py (left):

http://codereview.chromium.org/8688006/diff/2001/tools/valgrind/drmemory_anal...
tools/valgrind/drmemory_analyze.py:18: class _StackTraceLine(object):
copy-paste artifact from tsan_analyze.py

http://codereview.chromium.org/8688006/diff/2001/tools/valgrind/drmemory_anal...
tools/valgrind/drmemory_analyze.py:110: parser.add_option("", "--source_dir",
unused, since Dr. Memory handles this itself.

[Timur Iskhodzhanov, 2011-11-24 18:01:38]

Hm, all the tests are failing on the DrM bot with
[ RUN      ] WorkerTest.SingleWorker
python: can't open file 'tools/valgrind/browser_wrapper_win.py':
[Errno 2] No such file or directory

Strange: works fine locally. Maybe / vs \ error?
Will handle tomorrow.

On Thu, Nov 24, 2011 at 6:01 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Derek Bruening, Alexander Potapenko,
>
> Message:
> TBR
>
>
> http://codereview.chromium.org/8688006/diff/2001/tools/valgrind/common.py
> File tools/valgrind/common.py (right):
>
>
http://codereview.chromium.org/8688006/diff/2001/tools/valgrind/common.py#new...
> tools/valgrind/common.py:165:
> ("testing::internal::Handle*ExceptionsInMethodIfSupported*",
> Dr. Memory prints out the <...> template list which is ommited by TSan
> => wasn't matching.
>
>
http://codereview.chromium.org/8688006/diff/2001/tools/valgrind/common.py#new...
> tools/valgrind/common.py:219: def PrintUsedSuppressionsList(suppcounts):
> TODO: re-use this for Valgrind and TSan and HeapCheck.
> They use the same format, but at the cost of code duplication.
>
> This will be a follow-up CL.
>
>
http://codereview.chromium.org/8688006/diff/2001/tools/valgrind/drmemory_anal...
> File tools/valgrind/drmemory_analyze.py (left):
>
>
http://codereview.chromium.org/8688006/diff/2001/tools/valgrind/drmemory_anal...
> tools/valgrind/drmemory_analyze.py:18: class _StackTraceLine(object):
> copy-paste artifact from tsan_analyze.py
>
>
http://codereview.chromium.org/8688006/diff/2001/tools/valgrind/drmemory_anal...
> tools/valgrind/drmemory_analyze.py:110: parser.add_option("",
> "--source_dir",
> unused, since Dr. Memory handles this itself.
>
> Description:
> Set up python BROWSER_WRAPPER for ui_tests under Dr. Memory
>
> Also, clean-up and slightly re-design drmemory_analyze.py to be more like
> memcheck_analyze.py
> Looks like more refactoring can be done later to really share the code with
> Valgrind and TSan, esp. the BROWSER_WRAPPER itself.
> No idea why it was a bash script initially.
>
> TBR=bruening,glider
> TEST=ran tools\valgrind\chrome_tests.bat --tool drmemory_light --keep_logs
> -t
> base --gtest_filter="*Sanity*"
>     and ... -t ui --gtest_filter="RedirectTest.Server:RedirectTest.Client"
>     with tools/valgrind/drmemory/suppressions.txt removed
>
> Please review this at http://codereview.chromium.org/8688006/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  A     tools/valgrind/browser_wrapper_win.py
>  M     tools/valgrind/common.py
>  M     tools/valgrind/drmemory_analyze.py
>  M     tools/valgrind/valgrind_test.py
>
>
>