[cros, Aura] Change status area visibility during OOBE.

[cros, Aura] Change status area visibility during OOBE.

BUG=104133
TEST=During OOBE on Aura status area is only seen on login screen.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112689

[Nikita (slow), 2011-11-24 14:00:36]

Mostly changes are around exposing change of status area visibility &
enable/disable via ChromeShellDelegate/StatusAreaHostAura.

OOBE screens are changing status area visibility via
WebUILoginDisplayHost > WebUILoginDisplay > ChromeShellDelegate >
StatusAreaHostAura > StatusAreaView

[stevenjb, 2011-11-28 19:52:14]

It seems to me that, rather than adding a specialized API for setting enabled
and visibility, it would be reasonable to provide an accessor to the status
area? Then we could make status_area_ in WebUILoginView a StatusAreaView*, and
for Aura set it to
ChromeShellDelegate::instance()->status_area_host()->status_area_view() instead
of creating a ChromeosStatusAreaView.

[Nikita (slow), 2011-11-29 14:06:40]

Sure, that's more flexible approach.
Please take a look at the updated patch.

I've seen GetStatusAreaForTest() methods in ChromeShellDelegate /
StatusAreaHostAura that were specifically marked for testing only so I've
assumed exposing host / status area is not encouraged.

[Nikita (slow), 2011-11-30 08:29:25]

PTAL

[stevenjb, 2011-11-30 17:20:01]

LGTM (sorry for the delay, busy sheriff day)

[sky, 2011-11-30 17:47:50]

http://codereview.chromium.org/8688003/diff/11001/chrome/browser/ui/views/aur...
File chrome/browser/ui/views/aura/chrome_shell_delegate.h (right):

http://codereview.chromium.org/8688003/diff/11001/chrome/browser/ui/views/aur...
chrome/browser/ui/views/aura/chrome_shell_delegate.h:31: StatusAreaHostAura*
status_area_host() { return status_area_host_.get(); }
I believe this ends up exposing the same thing as GetStatusAreaForTest above.
Could we nuke this (and StatusAreaHostAura::status_area_view()) and rename
GetStatusAreaForTest to GetStatusArea?

[Nikita (slow), 2011-12-01 09:15:08]

Scott, please take a look.

http://codereview.chromium.org/8688003/diff/11001/chrome/browser/ui/views/aur...
File chrome/browser/ui/views/aura/chrome_shell_delegate.h (right):

http://codereview.chromium.org/8688003/diff/11001/chrome/browser/ui/views/aur...
chrome/browser/ui/views/aura/chrome_shell_delegate.h:31: StatusAreaHostAura*
status_area_host() { return status_area_host_.get(); }
On 2011/11/30 17:47:50, sky wrote:
> I believe this ends up exposing the same thing as GetStatusAreaForTest above.
> Could we nuke this (and StatusAreaHostAura::status_area_view()) and rename
> GetStatusAreaForTest to GetStatusArea?

Done.

[sky, 2011-12-01 17:05:03]

LGTM

[commit-bot: I haz the power, 2011-12-02 12:42:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nkostylev@chromium.org/8688003/17001

[commit-bot: I haz the power, 2011-12-02 13:59:09]

Change committed as 112689