PPB_TCPSocket_Private/PPB_UDPSocket_Private are exposed to Browser

webkit/plugins/ppapi/ppb_tcp_socket_private_impl.h

Index: webkit/plugins/ppapi/ppb_tcp_socket_private_impl.h
diff --git a/webkit/plugins/ppapi/ppb_tcp_socket_private_impl.h b/webkit/plugins/ppapi/ppb_tcp_socket_private_impl.h
new file mode 100644
index 0000000000000000000000000000000000000000..ea4975194816f84a95341745da69615b25e0e712
--- /dev/null
+++ b/webkit/plugins/ppapi/ppb_tcp_socket_private_impl.h
@@ -0,0 +1,36 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef WEBKIT_PLUGINS_PPAPI_PPB_TCP_SOCKET_PRIVATE_IMPL_H_
+#define WEBKIT_PLUGINS_PPAPI_PPB_TCP_SOCKET_PRIVATE_IMPL_H_
+
+#include "ppapi/shared_impl/tcp_socket_impl.h"
+
+namespace webkit {
+namespace ppapi {
+
+class PPB_TCPSocket_Private_Impl : public ::ppapi::TCPSocketImpl {
+ public:
+  static PP_Resource CreateResource(PP_Instance instance);
+
+  virtual void SendConnect(const std::string& host, uint16_t port);

[yzshen1, 2011/11/28 20:59:16]

Please use OVERRIDE.

[ygorshenin, 2011/11/29 18:30:09]

Done.

+  virtual void SendConnectWithNetAddress(const PP_NetAddress_Private& addr);
+  virtual void SendSSLHandshake(const std::string& server_name,
+                                uint16_t server_port);
+  virtual void SendRead(int32_t bytes_to_read);
+  virtual void SendWrite(const std::string& buffer);
+  virtual void SendDisconnect();
+  virtual void PostAbort(PP_CompletionCallback callback);
+
+ private:
+  PPB_TCPSocket_Private_Impl(PP_Instance instance, uint32 socket_id);
+  virtual ~PPB_TCPSocket_Private_Impl();

[yzshen1, 2011/11/28 20:59:16]

Is there any reason that we want to keep the destructor as private?

[ygorshenin, 2011/11/29 18:30:09]

On 2011/11/28 20:59:16, yzshen1 wrote:> Why it needs to be private?
There are no possibility to create instance of this class. Objects will be
destroyed via base class destructor. So, destructor is private only for
consistency with private constructor and readability.

+
+  DISALLOW_COPY_AND_ASSIGN(PPB_TCPSocket_Private_Impl);
+};
+
+}  // namespace ppapi
+}  // namespace webkit
+
+#endif  // WEBKIT_PLUGINS_PPAPI_PPB_TCP_SOCKET_PRIVATE_IMPL_H_