PPB_TCPSocket_Private/PPB_UDPSocket_Private are exposed to Browser

ppapi/shared_impl/tcp_socket_impl.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef PPAPI_SHARED_IMPL_TCP_SOCKET_IMPL_H_
+#define PPAPI_SHARED_IMPL_TCP_SOCKET_IMPL_H_
+
+#include <string>
+
+#include "base/compiler_specific.h"
+#include "ppapi/shared_impl/resource.h"
+#include "ppapi/thunk/ppb_tcp_socket_private_api.h"
+
+namespace ppapi {
+
+// This class provides the shared implementation of a PPB_TCPSocket_Private.
+// The functions that actually "do stuff" like Connect are implemented

[yzshen1, 2011/11/28 20:59:16]

I think the code that actually "do stuff" is in the browser process and exactly
the same.
Do you mean the way of sending messages is different?

Same comment for UDPSocket.

[ygorshenin, 2011/11/29 18:30:09]

Done.

+// differently for the proxied and non-proxied derived classes.
+class PPAPI_SHARED_EXPORT TCPSocketImpl
+    : public thunk::PPB_TCPSocket_Private_API,
+      public Resource {
+ public:
+  // C-tor used in Impl case.
+  TCPSocketImpl(PP_Instance instance, uint32 socket_id);
+  // C-tor used in Proxy case.
+  TCPSocketImpl(const HostResource& resource, uint32 socket_id);
+
+  virtual ~TCPSocketImpl();
+
+  // The maximum number of bytes that each PpapiHostMsg_PPBTCPSocket_Read
+  // message is allowed to request.
+  static const int32_t kMaxReadSize;
+  // The maximum number of bytes that each PpapiHostMsg_PPBTCPSocket_Write
+  // message is allowed to carry.
+  static const int32_t kMaxWriteSize;
+
+  // Resource overrides.
+  virtual PPB_TCPSocket_Private_API* AsPPB_TCPSocket_Private_API() OVERRIDE;
+
+  // PPB_TCPSocket_Private_API implementation.
+  virtual int32_t Connect(const char* host,
+                          uint16_t port,
+                          PP_CompletionCallback callback) OVERRIDE;
+  virtual int32_t ConnectWithNetAddress(
+      const PP_NetAddress_Private* addr,
+      PP_CompletionCallback callback) OVERRIDE;
+  virtual PP_Bool GetLocalAddress(PP_NetAddress_Private* local_addr) OVERRIDE;
+  virtual PP_Bool GetRemoteAddress(PP_NetAddress_Private* remote_addr) OVERRIDE;
+  virtual int32_t SSLHandshake(const char* server_name,
+                              uint16_t server_port,
+                              PP_CompletionCallback callback) OVERRIDE;
+  virtual int32_t Read(char* buffer,
+                      int32_t bytes_to_read,
+                      PP_CompletionCallback callback) OVERRIDE;
+  virtual int32_t Write(const char* buffer,
+                        int32_t bytes_to_write,
+                        PP_CompletionCallback callback) OVERRIDE;
+  virtual void Disconnect() OVERRIDE;
+
+  // Notifications on operations completion.
+  void OnConnectCompleted(bool succeeded,
+                          const PP_NetAddress_Private& local_addr,
+                          const PP_NetAddress_Private& remote_addr);
+  void OnSSLHandshakeCompleted(bool succeeded);
+  void OnReadCompleted(bool succeeded, const std::string& data);
+  void OnWriteCompleted(bool succeeded, int32_t bytes_written);
+
+  // Send functions that need to be implemented differently differently for

[yzshen1, 2011/11/28 20:59:16]

duplicate 'differently'

[ygorshenin, 2011/11/29 18:30:09]

Done.

+  // the proxied and non-proxied derived classes.
+  virtual void SendConnect(const std::string& host, uint16_t port) = 0;
+  virtual void SendConnectWithNetAddress(const PP_NetAddress_Private& addr) = 0;
+  virtual void SendSSLHandshake(const std::string& server_name,
+                                uint16_t server_port) = 0;
+  virtual void SendRead(int32_t bytes_to_read) = 0;
+  virtual void SendWrite(const std::string& buffer) = 0;
+  virtual void SendDisconnect() = 0;
+  virtual void PostAbort(PP_CompletionCallback callback) = 0;

[yzshen1, 2011/11/28 20:59:16]

Is there any reason we need to let subclasses implement this method? The
implementation (as well as the Task class) at both renderer / plugin side looks
the same to me.

Same comment for PostAbort() in UDPSocket.

[ygorshenin, 2011/11/29 18:30:09]

Yes. Base class is placed into ppapi/shared_impl directory. This is
ideologically incorrect to include "base/message_loop.h" and other chrome
headers from this directory.

[yzshen1, 2011/11/30 21:11:04]

I don't think it is an issue to use "base/message_loop.h" in shared_impl.
(I have also double-checked with vtl and brettw.)

[ygorshenin, 2011/12/01 10:58:31]

Done.

+
+ protected:
+  enum ConnectionState {
+    // Before a connection is successfully established (including a connect
+    // request is pending or a previous connect request failed).
+    BEFORE_CONNECT,
+    // A connection has been successfully established (including a request of
+    // initiating SSL is pending).
+    CONNECTED,
+    // An SSL connection has been successfully established.
+    SSL_CONNECTED,
+    // The connection has been ended.
+    DISCONNECTED
+  };
+
+  void Init(uint32 socket_id);
+  bool IsConnected() const;
+  void PostAbortAndClearIfNecessary(PP_CompletionCallback* callback);
+
+  uint32 socket_id_;
+  ConnectionState connection_state_;
+
+  PP_CompletionCallback connect_callback_;
+  PP_CompletionCallback ssl_handshake_callback_;
+  PP_CompletionCallback read_callback_;
+  PP_CompletionCallback write_callback_;
+
+  char* read_buffer_;
+  int32_t bytes_to_read_;
+
+  PP_NetAddress_Private local_addr_;
+  PP_NetAddress_Private remote_addr_;
+
+  DISALLOW_COPY_AND_ASSIGN(TCPSocketImpl);
+};
+
+}  // namespace ppapi
+
+#endif  // PPAPI_SHARED_IMPL_TCP_SOCKET_IMPL_H_