Very first steps for a debugger

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_state.h"
 #include "vm/dart_entry.h"
+#include "vm/debugger.h"
 #include "vm/debuginfo.h"
 #include "vm/exceptions.h"
 #include "vm/growable_array.h"
 #include "vm/longjump.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
 #include "vm/port.h"
 #include "vm/resolver.h"
 #include "vm/snapshot.h"
@@ skipping 1532 matching lines @@
 // which shows up because of the use of setjmp.
 static void InvokeStatic(Isolate* isolate,
                          const Function& function,
                          GrowableArray<const Object*>& args,
                          Dart_Handle* result) {
   ASSERT(isolate != NULL);
   LongJump* base = isolate->long_jump_base();
   LongJump jump;
   isolate->set_long_jump_base(&jump);
   if (setjmp(*jump.Set()) == 0) {
+    isolate->debugger()->Initialize(isolate);

[siva, 2011/11/30 00:00:47]

Why do we have to wait until InvokeStatic is called to initialize the debugger,
why not do it as part of isolate initialization.

[hausner, 2011/11/30 01:17:05]

Because I need to wait until all the code is loaded in the isolate before I can
set a breakpoint. I could initialize the debugger sooner, but processing the
command line option to set the breakpoint would still have to be done at this
point.

     const Array& kNoArgumentNames = Array::Handle();
     const Instance& retval = Instance::Handle(
         DartEntry::InvokeStatic(function, args, kNoArgumentNames));
     if (retval.IsUnhandledException()) {
       *result = Api::ErrorFromException(retval);
     } else {
       *result = Api::NewLocalHandle(retval);
     }
   } else {
     SetupErrorResult(result);
@@ skipping 721 matching lines @@
     }
     delete debug_region;
   } else {
     *buffer = NULL;
     *buffer_size = 0;
   }
 }
 
 
 }  // namespace dart