Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 8687027: IME (input method editor) support for Aura, part 2 of 3: Add views::InputMethodBridge (Closed)

Created:
9 years ago by Yusuke Sato
Modified:
9 years ago
Reviewers:
James Su, sky
CC:
chromium-reviews, yusukes+watch_chromium.org, tfarina, penghuang+watch_chromium.org, brettw-cc_chromium.org, James Su, dhollowa
Visibility:
Public.

Description

IME (input method editor) support for Aura, part 2 of 3: Add views::InputMethodBridge InputMethodBridge: - Implements ui::TextInputClient interface, and receives IME results (e.g. composition text) from ui::InputMethod and forwards them to UI (e.g. a text field). - Also receives a request like 'CancelComposition' from the UI and forwards it to ui::InputMethod. Original review: http://codereview.chromium.org/8576005/ (PatchSet #1-8, Comment #1-24) BUG=97261 TEST=see part 3 of 3. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113131

Patch Set 1 #

Patch Set 2 : review #

Total comments: 2

Patch Set 3 : added a TODO #

Patch Set 4 : fix view.h path #

Patch Set 5 : rebase #

Patch Set 6 : final rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -0 lines) Patch
M ui/views/ime/input_method_base.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A ui/views/ime/input_method_bridge.h View 1 chunk +82 lines, -0 lines 0 comments Download
A ui/views/ime/input_method_bridge.cc View 1 2 3 1 chunk +204 lines, -0 lines 0 comments Download
M ui/views/ime/input_method_ibus.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/ime/input_method_ibus.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/views.gyp View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yusuke Sato
part 2 of 3.
9 years ago (2011-11-29 11:32:55 UTC) #1
James Su
LGTM. http://codereview.chromium.org/8687027/diff/2001/ui/views/ime/input_method_bridge.cc File ui/views/ime/input_method_bridge.cc (right): http://codereview.chromium.org/8687027/diff/2001/ui/views/ime/input_method_bridge.cc#newcode40 ui/views/ime/input_method_bridge.cc:40: OnTextInputTypeChanged(GetFocusedView()); We don't need to call it anymore ...
9 years ago (2011-11-30 05:25:40 UTC) #2
Yusuke Sato
http://codereview.chromium.org/8687027/diff/2001/ui/views/ime/input_method_bridge.cc File ui/views/ime/input_method_bridge.cc (right): http://codereview.chromium.org/8687027/diff/2001/ui/views/ime/input_method_bridge.cc#newcode40 ui/views/ime/input_method_bridge.cc:40: OnTextInputTypeChanged(GetFocusedView()); On 2011/11/30 05:25:40, James Su wrote: > We ...
9 years ago (2011-12-01 04:03:21 UTC) #3
Yusuke Sato
+sky (OWNER of ui/views/views.gyp)
9 years ago (2011-12-03 08:23:26 UTC) #4
sky
LGTM
9 years ago (2011-12-05 15:16:22 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-06 03:50:37 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698