Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Issue 8687016: GLContextNSView should not assume concrete type GLSurface is GLSurfaceNSView (Closed)

Created:
9 years ago by dhollowa
Modified:
9 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

GLContextNSView should not assume concrete type GLSurface is GLSurfaceNSView This is follow-up from review http://codereview.chromium.org/8486020. This eliminates down-cast of GLSurface in CLContextNSView::Initialize in favor of GLSurfaceNSView::OnMakeCurrent implementation. Also, allows offscreen path in USE_AURA due to its usage in SharedResourcesCC. BUG=104390 TEST=compositor_unittests --gtest_filter=LayerWithRealCompositorTest.* R=apatrick@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112231

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M ui/gfx/gl/gl_context_mac.mm View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/gfx/gl/gl_context_nsview.mm View 2 chunks +6 lines, -3 lines 0 comments Download
M ui/gfx/gl/gl_surface_nsview.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gl/gl_surface_nsview.mm View 1 chunk +3 lines, -2 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
dhollowa
9 years ago (2011-11-28 23:57:15 UTC) #1
Ken Russell (switch to Gerrit)
9 years ago (2011-11-30 00:39:01 UTC) #2
LGTM

http://codereview.chromium.org/8687016/diff/1/ui/gfx/gl/gl_surface_nsview.mm
File ui/gfx/gl/gl_surface_nsview.mm (right):

http://codereview.chromium.org/8687016/diff/1/ui/gfx/gl/gl_surface_nsview.mm#...
ui/gfx/gl/gl_surface_nsview.mm:43: context_ = static_cast<GLContextNSView
*>(context);
Given the other cleanup in this CL, the downcast is unfortunate. This is the
first platform that has different context types for different surfaces.
Presumably MakeCurrent should do some validation that you're using compatible
contexts and surfaces. Anyway, this is a cleanup for the future.

Powered by Google App Engine
This is Rietveld 408576698