Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 8687013: Get the examples to run in aura_shell. (Closed)

Created:
9 years ago by Ben Goodger (Google)
Modified:
9 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, dhollowa, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

jGet the examples to run in aura_shell. . Reorganizes views_examples target into two: views_examples_lib (a component) and views_examples_exe (a runner in views, which builds in Aura but does not run without crashing due to lack of desktop environment). . Refactors ExamplesMain into ExamplesWindowContents, a contents view that hosts the examples UI. Makes a publicly exported function from views examples to show a window containing this view. . Moves the examples into the views namespace. . Adds a button to launch the ExamplesWindow inside aura_shell. . Adds a NativeTabbedPaneViews to host the examples content. This is not a production class and is mostly just intended to get something onto the screen. The code is copy-pasta from NativeTabbedPaneWin. I imagine we can get rid of all of this once we stop using TabbedPanes in Chrome. http://crbug.com/105622 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111954

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 5

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1214 lines, -924 lines) Patch
M ui/aura_shell/aura_shell.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura_shell/examples/window_type_launcher.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura_shell/examples/window_type_launcher.cc View 1 2 5 chunks +13 lines, -1 line 0 comments Download
A ui/views/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
A ui/views/controls/tabbed_pane/native_tabbed_pane_views.h View 1 2 1 chunk +77 lines, -0 lines 0 comments Download
A ui/views/controls/tabbed_pane/native_tabbed_pane_views.cc View 1 2 1 chunk +348 lines, -0 lines 0 comments Download
M ui/views/examples/bubble_example.h View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
M ui/views/examples/bubble_example.cc View 1 2 6 chunks +20 lines, -20 lines 0 comments Download
M ui/views/examples/button_example.h View 1 2 2 chunks +8 lines, -9 lines 0 comments Download
M ui/views/examples/button_example.cc View 1 2 6 chunks +21 lines, -20 lines 0 comments Download
M ui/views/examples/combobox_example.h View 1 2 1 chunk +8 lines, -7 lines 0 comments Download
M ui/views/examples/combobox_example.cc View 1 2 2 chunks +7 lines, -6 lines 0 comments Download
M ui/views/examples/double_split_view_example.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M ui/views/examples/double_split_view_example.cc View 1 2 1 chunk +13 lines, -11 lines 0 comments Download
M ui/views/examples/example_base.h View 1 2 4 chunks +2 lines, -7 lines 0 comments Download
M ui/views/examples/example_base.cc View 1 2 4 chunks +18 lines, -12 lines 0 comments Download
M ui/views/examples/example_combobox_model.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M ui/views/examples/example_combobox_model.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M ui/views/examples/examples_main.cc View 1 2 2 chunks +2 lines, -138 lines 0 comments Download
A + ui/views/examples/examples_window.h View 1 2 3 1 chunk +5 lines, -49 lines 0 comments Download
A + ui/views/examples/examples_window.cc View 1 3 chunks +105 lines, -130 lines 0 comments Download
M ui/views/examples/link_example.h View 1 2 1 chunk +7 lines, -8 lines 0 comments Download
M ui/views/examples/link_example.cc View 1 2 1 chunk +7 lines, -6 lines 0 comments Download
M ui/views/examples/menu_example.h View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M ui/views/examples/menu_example.cc View 1 2 6 chunks +16 lines, -16 lines 0 comments Download
M ui/views/examples/message_box_example.h View 1 2 1 chunk +9 lines, -11 lines 0 comments Download
M ui/views/examples/message_box_example.cc View 1 2 3 chunks +16 lines, -16 lines 0 comments Download
M ui/views/examples/native_theme_button_example.h View 1 2 4 chunks +19 lines, -21 lines 0 comments Download
M ui/views/examples/native_theme_button_example.cc View 1 2 6 chunks +25 lines, -23 lines 0 comments Download
M ui/views/examples/native_theme_checkbox_example.h View 1 2 2 chunks +7 lines, -9 lines 0 comments Download
M ui/views/examples/native_theme_checkbox_example.cc View 1 2 1 chunk +9 lines, -7 lines 0 comments Download
M ui/views/examples/progress_bar_example.h View 1 2 1 chunk +9 lines, -11 lines 0 comments Download
M ui/views/examples/progress_bar_example.cc View 1 2 3 chunks +17 lines, -16 lines 0 comments Download
M ui/views/examples/radio_button_example.h View 1 2 2 chunks +10 lines, -10 lines 0 comments Download
M ui/views/examples/radio_button_example.cc View 1 2 3 chunks +14 lines, -12 lines 0 comments Download
M ui/views/examples/scroll_view_example.h View 1 2 1 chunk +13 lines, -13 lines 0 comments Download
M ui/views/examples/scroll_view_example.cc View 1 2 5 chunks +22 lines, -23 lines 0 comments Download
M ui/views/examples/single_split_view_example.h View 1 2 1 chunk +7 lines, -5 lines 0 comments Download
M ui/views/examples/single_split_view_example.cc View 1 2 4 chunks +16 lines, -15 lines 0 comments Download
M ui/views/examples/tabbed_pane_example.h View 1 2 2 chunks +13 lines, -14 lines 0 comments Download
M ui/views/examples/tabbed_pane_example.cc View 1 2 4 chunks +18 lines, -19 lines 0 comments Download
M ui/views/examples/table2_example.h View 1 2 3 chunks +15 lines, -16 lines 0 comments Download
M ui/views/examples/table2_example.cc View 1 2 5 chunks +29 lines, -29 lines 0 comments Download
M ui/views/examples/table_example.h View 1 2 3 chunks +15 lines, -16 lines 0 comments Download
M ui/views/examples/table_example.cc View 1 2 5 chunks +24 lines, -25 lines 0 comments Download
M ui/views/examples/text_example.h View 1 2 2 chunks +20 lines, -21 lines 0 comments Download
M ui/views/examples/text_example.cc View 1 2 7 chunks +24 lines, -24 lines 0 comments Download
M ui/views/examples/textfield_example.h View 1 2 2 chunks +17 lines, -16 lines 0 comments Download
M ui/views/examples/textfield_example.cc View 1 2 4 chunks +24 lines, -23 lines 0 comments Download
M ui/views/examples/throbber_example.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/examples/throbber_example.cc View 1 2 3 chunks +11 lines, -10 lines 0 comments Download
M ui/views/examples/widget_example.h View 1 2 2 chunks +11 lines, -10 lines 0 comments Download
M ui/views/examples/widget_example.cc View 1 2 7 chunks +30 lines, -31 lines 0 comments Download
M views/views.gyp View 1 2 3 11 chunks +61 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
Look at: native_tabbed_pane_views examples_window* examples_main example_base gyp files the rest is mostly just api changes.
9 years ago (2011-11-28 23:03:30 UTC) #1
sky
9 years ago (2011-11-28 23:46:22 UTC) #2
LGTM

http://codereview.chromium.org/8687013/diff/67/ui/views/controls/tabbed_pane/...
File ui/views/controls/tabbed_pane/native_tabbed_pane_views.cc (right):

http://codereview.chromium.org/8687013/diff/67/ui/views/controls/tabbed_pane/...
ui/views/controls/tabbed_pane/native_tabbed_pane_views.cc:117: // Switches to
the tab page identified by the given index.
update comment (no index)

http://codereview.chromium.org/8687013/diff/67/ui/views/controls/tabbed_pane/...
ui/views/controls/tabbed_pane/native_tabbed_pane_views.cc:137: virtual void
Layout(View* host) {
OVERRIDE

http://codereview.chromium.org/8687013/diff/67/ui/views/controls/tabbed_pane/...
ui/views/controls/tabbed_pane/native_tabbed_pane_views.cc:175:
ALLOW_THIS_IN_INITIALIZER_LIST(tab_strip_(new TabStrip(this))),
make order match header.

http://codereview.chromium.org/8687013/diff/67/ui/views/controls/tabbed_pane/...
File ui/views/controls/tabbed_pane/native_tabbed_pane_views.h (right):

http://codereview.chromium.org/8687013/diff/67/ui/views/controls/tabbed_pane/...
ui/views/controls/tabbed_pane/native_tabbed_pane_views.h:29: virtual void
AddTab(const string16& title, View* contents);
OVERRIDE all these

http://codereview.chromium.org/8687013/diff/67/ui/views/controls/tabbed_pane/...
ui/views/controls/tabbed_pane/native_tabbed_pane_views.h:74: std::vector<View*>
tab_views_;
Seems slightly less error prone to create a struct (TabDetails?) and then have a
vector of TabDetails. That way you don't have to worry about keeping two vectors
in sync.

Powered by Google App Engine
This is Rietveld 408576698