Issue 8687005: checkbins.py: skip /SAFESEH check on 64-bit Windows binaries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8687005: checkbins.py: skip /SAFESEH check on 64-bit Windows binaries (Closed)

Created:
9 years ago by scherkus (not reviewing)

Modified:
9 years ago

Reviewers:
jschuh, M-A Ruel, Sigurður Ásgeirsson

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

checkbins.py: skip /SAFESEH check on 64-bit Windows binaries As mentioned in http://msdn.microsoft.com/en-us/library/9a89h429.aspx /SAFESEH is only valid for x86 targets as x64 targets have exception handlers noted in their PDATA section. BUG=104188 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111770

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	tools/checkbins/checkbins.py	View		2 chunks	+11 lines, -5 lines	0 comments	Download

Total messages: 5 (0 generated)

jschuh

On 2011/11/28 19:42:28, Marc-Antoine Ruel wrote: > lgtm lgtm, but would you mind adding siggi ...

9 years ago (2011-11-28 19:44:50 UTC) #3

lgtm - nice link!