Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: chrome/browser/autofill/phone_number_i18n_unittest.cc

Issue 8687002: Cleanup: Convert ASCIIToUTF16("") to string16(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/form_field_unittest.cc ('k') | chrome/browser/autofill/phone_number_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/phone_number_i18n_unittest.cc
diff --git a/chrome/browser/autofill/phone_number_i18n_unittest.cc b/chrome/browser/autofill/phone_number_i18n_unittest.cc
index 762b9089171360456b884b519456feb5171c8605..d75c320c1ec8beda60c8bbc0a6d58867882cd0de 100644
--- a/chrome/browser/autofill/phone_number_i18n_unittest.cc
+++ b/chrome/browser/autofill/phone_number_i18n_unittest.cc
@@ -3,6 +3,7 @@
// found in the LICENSE file.
#include "base/message_loop.h"
+#include "base/string16.h"
#include "base/utf_string_conversions.h"
#include "chrome/browser/autofill/phone_number_i18n.h"
#include "content/test/test_browser_thread.h"
@@ -287,22 +288,22 @@ TEST_F(PhoneNumberI18NTest, ConstructPhoneNumber) {
autofill_i18n::RFC3966,
&number));
EXPECT_EQ(number, ASCIIToUTF16("+1-650-234-5678"));
- EXPECT_TRUE(ConstructPhoneNumber(ASCIIToUTF16(""),
+ EXPECT_TRUE(ConstructPhoneNumber(string16(),
ASCIIToUTF16("650"),
ASCIIToUTF16("2345678"),
"US",
autofill_i18n::INTERNATIONAL,
&number));
EXPECT_EQ(number, ASCIIToUTF16("+1 650-234-5678"));
- EXPECT_TRUE(ConstructPhoneNumber(ASCIIToUTF16(""),
- ASCIIToUTF16(""),
+ EXPECT_TRUE(ConstructPhoneNumber(string16(),
+ string16(),
ASCIIToUTF16("6502345678"),
"US",
autofill_i18n::INTERNATIONAL,
&number));
EXPECT_EQ(number, ASCIIToUTF16("+1 650-234-5678"));
- EXPECT_FALSE(ConstructPhoneNumber(ASCIIToUTF16(""),
+ EXPECT_FALSE(ConstructPhoneNumber(string16(),
ASCIIToUTF16("650"),
ASCIIToUTF16("234567890"),
"US",
@@ -310,7 +311,7 @@ TEST_F(PhoneNumberI18NTest, ConstructPhoneNumber) {
&number));
EXPECT_EQ(number, string16());
// Italian number
- EXPECT_TRUE(ConstructPhoneNumber(ASCIIToUTF16(""),
+ EXPECT_TRUE(ConstructPhoneNumber(string16(),
ASCIIToUTF16("347"),
ASCIIToUTF16("2345678"),
"IT",
« no previous file with comments | « chrome/browser/autofill/form_field_unittest.cc ('k') | chrome/browser/autofill/phone_number_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698