Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: base/string_piece_unittest.cc

Issue 8687002: Cleanup: Convert ASCIIToUTF16("") to string16(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/i18n/string_search_unittest.cc ('k') | base/string_util_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/string16.h"
7 #include "base/string_piece.h" 8 #include "base/string_piece.h"
8 #include "base/utf_string_conversions.h" 9 #include "base/utf_string_conversions.h"
9 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
10 11
11 namespace base { 12 namespace base {
12 13
13 TEST(StringPieceTest, CheckComparisonOperators) { 14 TEST(StringPieceTest, CheckComparisonOperators) {
14 #define CMP_Y(op, x, y) \ 15 #define CMP_Y(op, x, y) \
15 ASSERT_TRUE( (StringPiece((x)) op StringPiece((y)))); \ 16 ASSERT_TRUE( (StringPiece((x)) op StringPiece((y)))); \
16 ASSERT_TRUE( (StringPiece((x)).compare(StringPiece((y))) op 0)) 17 ASSERT_TRUE( (StringPiece((x)).compare(StringPiece((y))) op 0))
(...skipping 518 matching lines...) Expand 10 before | Expand all | Expand 10 after
535 ASSERT_TRUE("hello" == std::string("hello")); 536 ASSERT_TRUE("hello" == std::string("hello"));
536 ASSERT_TRUE("hello" < std::string("world")); 537 ASSERT_TRUE("hello" < std::string("world"));
537 } 538 }
538 539
539 TEST(StringPieceTest, HeterogenousStringPieceEquals) { 540 TEST(StringPieceTest, HeterogenousStringPieceEquals) {
540 ASSERT_TRUE(StringPiece("hello") == std::string("hello")); 541 ASSERT_TRUE(StringPiece("hello") == std::string("hello"));
541 ASSERT_TRUE("hello" == StringPiece("hello")); 542 ASSERT_TRUE("hello" == StringPiece("hello"));
542 } 543 }
543 544
544 TEST(StringPiece16Test, CheckComparisonOperators) { 545 TEST(StringPiece16Test, CheckComparisonOperators) {
545 ASSERT_TRUE(StringPiece16(ASCIIToUTF16("")) == 546 ASSERT_TRUE(StringPiece16(string16()) ==
546 StringPiece16(ASCIIToUTF16(""))); 547 StringPiece16(string16()));
547 ASSERT_TRUE(StringPiece16(ASCIIToUTF16("a")) == 548 ASSERT_TRUE(StringPiece16(ASCIIToUTF16("a")) ==
548 StringPiece16(ASCIIToUTF16("a"))); 549 StringPiece16(ASCIIToUTF16("a")));
549 ASSERT_TRUE(StringPiece16(ASCIIToUTF16("aa")) == 550 ASSERT_TRUE(StringPiece16(ASCIIToUTF16("aa")) ==
550 StringPiece16(ASCIIToUTF16("aa"))); 551 StringPiece16(ASCIIToUTF16("aa")));
551 ASSERT_FALSE(StringPiece16(ASCIIToUTF16("a")) == 552 ASSERT_FALSE(StringPiece16(ASCIIToUTF16("a")) ==
552 StringPiece16(ASCIIToUTF16(""))); 553 StringPiece16(string16()));
553 ASSERT_FALSE(StringPiece16(ASCIIToUTF16("")) == 554 ASSERT_FALSE(StringPiece16(string16()) ==
554 StringPiece16(ASCIIToUTF16("a"))); 555 StringPiece16(ASCIIToUTF16("a")));
555 ASSERT_FALSE(StringPiece16(ASCIIToUTF16("a")) == 556 ASSERT_FALSE(StringPiece16(ASCIIToUTF16("a")) ==
556 StringPiece16(ASCIIToUTF16("b"))); 557 StringPiece16(ASCIIToUTF16("b")));
557 ASSERT_FALSE(StringPiece16(ASCIIToUTF16("a")) == 558 ASSERT_FALSE(StringPiece16(ASCIIToUTF16("a")) ==
558 StringPiece16(ASCIIToUTF16("aa"))); 559 StringPiece16(ASCIIToUTF16("aa")));
559 ASSERT_FALSE(StringPiece16(ASCIIToUTF16("aa")) == 560 ASSERT_FALSE(StringPiece16(ASCIIToUTF16("aa")) ==
560 StringPiece16(ASCIIToUTF16("a"))); 561 StringPiece16(ASCIIToUTF16("a")));
561 562
562 ASSERT_FALSE(StringPiece16(ASCIIToUTF16("")) != 563 ASSERT_FALSE(StringPiece16(string16()) !=
563 StringPiece16(ASCIIToUTF16(""))); 564 StringPiece16(string16()));
564 ASSERT_FALSE(StringPiece16(ASCIIToUTF16("a")) != 565 ASSERT_FALSE(StringPiece16(ASCIIToUTF16("a")) !=
565 StringPiece16(ASCIIToUTF16("a"))); 566 StringPiece16(ASCIIToUTF16("a")));
566 ASSERT_FALSE(StringPiece16(ASCIIToUTF16("aa")) != 567 ASSERT_FALSE(StringPiece16(ASCIIToUTF16("aa")) !=
567 StringPiece16(ASCIIToUTF16("aa"))); 568 StringPiece16(ASCIIToUTF16("aa")));
568 ASSERT_TRUE(StringPiece16(ASCIIToUTF16("a")) != 569 ASSERT_TRUE(StringPiece16(ASCIIToUTF16("a")) !=
569 StringPiece16(ASCIIToUTF16(""))); 570 StringPiece16(string16()));
570 ASSERT_TRUE(StringPiece16(ASCIIToUTF16("")) != 571 ASSERT_TRUE(StringPiece16(string16()) !=
571 StringPiece16(ASCIIToUTF16("a"))); 572 StringPiece16(ASCIIToUTF16("a")));
572 ASSERT_TRUE(StringPiece16(ASCIIToUTF16("a")) != 573 ASSERT_TRUE(StringPiece16(ASCIIToUTF16("a")) !=
573 StringPiece16(ASCIIToUTF16("b"))); 574 StringPiece16(ASCIIToUTF16("b")));
574 ASSERT_TRUE(StringPiece16(ASCIIToUTF16("a")) != 575 ASSERT_TRUE(StringPiece16(ASCIIToUTF16("a")) !=
575 StringPiece16(ASCIIToUTF16("aa"))); 576 StringPiece16(ASCIIToUTF16("aa")));
576 ASSERT_TRUE(StringPiece16(ASCIIToUTF16("aa")) != 577 ASSERT_TRUE(StringPiece16(ASCIIToUTF16("aa")) !=
577 StringPiece16(ASCIIToUTF16("a"))); 578 StringPiece16(ASCIIToUTF16("a")));
578 579
579 ASSERT_TRUE(StringPiece16(ASCIIToUTF16("a")) < 580 ASSERT_TRUE(StringPiece16(ASCIIToUTF16("a")) <
580 StringPiece16(ASCIIToUTF16("b"))); 581 StringPiece16(ASCIIToUTF16("b")));
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
765 TEST(StringPiece16Test, CheckConversion) { 766 TEST(StringPiece16Test, CheckConversion) {
766 // Make sure that we can convert from UTF8 to UTF16 and back. We use a two 767 // Make sure that we can convert from UTF8 to UTF16 and back. We use a two
767 // byte character (G clef) to test this. 768 // byte character (G clef) to test this.
768 ASSERT_EQ( 769 ASSERT_EQ(
769 UTF16ToUTF8( 770 UTF16ToUTF8(
770 StringPiece16(UTF8ToUTF16("\xf0\x9d\x84\x9e")).as_string16()), 771 StringPiece16(UTF8ToUTF16("\xf0\x9d\x84\x9e")).as_string16()),
771 "\xf0\x9d\x84\x9e"); 772 "\xf0\x9d\x84\x9e");
772 } 773 }
773 774
774 } // namespace base 775 } // namespace base
OLDNEW
« no previous file with comments | « base/i18n/string_search_unittest.cc ('k') | base/string_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698