Issue 8686014: Remove child_process.h includes from chrome (specifically WaitForDebugger). I moved the browser p...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8686014: Remove child_process.h includes from chrome (specifically WaitForDebugger). I moved the browser p... (Closed)

Created:
9 years ago by jam

Modified:
9 years ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, native-client-reviews_googlegroups.com, jam, dpranke-watch+content_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove child_process.h includes from chrome (specifically WaitForDebugger). I moved the browser process usage to content. For the NaCl usage, it wasn't working anyways since it wasn't being passed to the process (and if it was, the message box wouldn't work on Windows because of sandbox). When this is needed again, we can figure out a good way of doing it. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112259

Patch Set 1 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -32 lines)			Patch
M	chrome/browser/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chrome_browser_main.cc	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/nacl/nacl_main.cc	View	1 chunk	+0 lines, -19 lines	0 comments	Download
M	content/browser/browser_main.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages