Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: chrome/browser/ui/panels/panel_window_controller_cocoa.mm

Issue 8686012: Make panels not show on top when there is an app running in full screen mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge/Resolve. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/panels/panel_window_controller_cocoa.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/panel_window_controller_cocoa.mm
diff --git a/chrome/browser/ui/panels/panel_window_controller_cocoa.mm b/chrome/browser/ui/panels/panel_window_controller_cocoa.mm
index cf3d598267813df31a0f25bc48ad8592714a4df6..590bc50e69d1c8d84ac3579fe07a631a0cb3f2df 100644
--- a/chrome/browser/ui/panels/panel_window_controller_cocoa.mm
+++ b/chrome/browser/ui/panels/panel_window_controller_cocoa.mm
@@ -112,7 +112,8 @@ enum {
DCHECK(titlebar_view_);
DCHECK_EQ(self, [window delegate]);
- [window setLevel:NSStatusWindowLevel];
+ if (!windowShim_->panel()->manager()->is_full_screen())
+ [window setLevel:NSStatusWindowLevel];
if (base::mac::IsOSSnowLeopardOrLater()) {
[window setCollectionBehavior:
@@ -610,6 +611,11 @@ enum {
[NSApp deactivate];
}
+- (void)fullScreenModeChanged:(bool)isFullScreen {
+ NSWindow* window = [self window];
+ [window setLevel:(isFullScreen ? NSNormalWindowLevel : NSStatusWindowLevel)];
+}
+
- (BOOL)canBecomeKeyWindow {
// Panel can only gain focus if it is expanded. Minimized panels do not
// participate in Cmd-~ rotation.
« no previous file with comments | « chrome/browser/ui/panels/panel_window_controller_cocoa.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698