chrome/browser/ui/panels/panel_strip.cc - Issue 8686012: Make panels not show on top when there is an app running in full screen mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_strip.cc

Issue 8686012: Make panels not show on top when there is an app running in full screen mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Code review feedback. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/panels/panel_manager.cc ('K') | « chrome/browser/ui/panels/panel_strip.h ('k') | chrome/browser/ui/panels/panel_window_controller_cocoa.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/panels/panel_strip.cc

diff --git a/chrome/browser/ui/panels/panel_strip.cc b/chrome/browser/ui/panels/panel_strip.cc

index e62e34bb5383011e9bebd6f733f7be8853f810f3..6a740d822fcb15e8b50bf86a2a6761a4a7847e98 100644

--- a/chrome/browser/ui/panels/panel_strip.cc

+++ b/chrome/browser/ui/panels/panel_strip.cc

@@ -10,6 +10,7 @@

#include "base/logging.h"

#include "base/message_loop.h"

#include "chrome/browser/ui/browser.h"

+#include "chrome/browser/ui/panels/native_panel.h"

#include "chrome/browser/ui/panels/panel_manager.h"

#include "chrome/browser/ui/panels/panel_mouse_watcher.h"

#include "chrome/common/chrome_notification_types.h"

@@ -545,6 +546,11 @@ void PanelStrip::OnAutoHidingDesktopBarVisibilityChanged(

delayed_titlebar_action_ = NO_ACTION;

}

+void PanelStrip::OnFullScreenModeChanged(bool is_full_screen_mode_on) {

+ for (size_t i = 0; i < panels_.size(); ++i)

+ panels_[i]->native_panel()->FullScreenModeChanged(is_full_screen_mode_on);

void PanelStrip::Rearrange(Panels::iterator iter_to_start,

int rightmost_position) {

for (Panels::iterator iter = iter_to_start; iter != panels_.end(); ++iter) {