Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: chrome/browser/ui/panels/panel_browser_view.cc

Issue 8686012: Make panels not show on top when there is an app running in full screen mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_browser_view.cc
diff --git a/chrome/browser/ui/panels/panel_browser_view.cc b/chrome/browser/ui/panels/panel_browser_view.cc
index 0a887e2e5106c468c3f6da82f4a9c8dd84b48ee0..5227a348355002be11d434972ac51e174df6c578 100644
--- a/chrome/browser/ui/panels/panel_browser_view.cc
+++ b/chrome/browser/ui/panels/panel_browser_view.cc
@@ -60,6 +60,11 @@ PanelBrowserView::~PanelBrowserView() {
}
void PanelBrowserView::Init() {
+ if (!panel_->manager()->is_full_screen_mode_on()) {
+ // TODO(prasadt): Implement this code.
+ // Turn off always on top for the panel.
jianli 2011/11/30 01:53:15 Can you update the comment and all others to indic
prasadt 2011/11/30 02:38:47 Done.
+ }
+
BrowserView::Init();
GetWidget()->non_client_view()->SetAccessibleName(
@@ -346,6 +351,14 @@ bool PanelBrowserView::PreHandlePanelKeyboardEvent(
return PreHandleKeyboardEvent(event, is_keyboard_shortcut);
}
+void PanelBrowserView::FullScreenModeChanged(bool is_full_screen_mode_on) {
+ // TODO(prasadt): Enable this code.
+ // if (is_full_screen_mode_on)
+ // TurnOnAlwaysOnTop.
+ // else
+ // TurnOffAlwaysOnTop.
+}
+
void PanelBrowserView::HandlePanelKeyboardEvent(
const NativeWebKeyboardEvent& event) {
HandleKeyboardEvent(event);

Powered by Google App Engine
This is Rietveld 408576698