Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: chrome/browser/ui/panels/panel_window_controller_cocoa.mm

Issue 8686012: Make panels not show on top when there is an app running in full screen mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_window_controller_cocoa.mm
diff --git a/chrome/browser/ui/panels/panel_window_controller_cocoa.mm b/chrome/browser/ui/panels/panel_window_controller_cocoa.mm
index 06e69df40e587410dc730d05bad69c18ca377ad3..6cf68aed0a84a98a1adea1c33f22a623c557d31f 100644
--- a/chrome/browser/ui/panels/panel_window_controller_cocoa.mm
+++ b/chrome/browser/ui/panels/panel_window_controller_cocoa.mm
@@ -112,7 +112,8 @@ enum {
DCHECK(titlebar_view_);
DCHECK_EQ(self, [window delegate]);
- [window setLevel:NSStatusWindowLevel];
+ if (!windowShim_->panel()->manager()->is_full_screen_mode_on())
+ [window setLevel:NSStatusWindowLevel];
if (base::mac::IsOSSnowLeopardOrLater()) {
[window setCollectionBehavior:
@@ -566,6 +567,14 @@ enum {
[NSApp deactivate];
}
+- (void)fullScreenModeChanged:(bool)isFullScreenModeOn {
+ NSWindow* window = [self window];
+ if (isFullScreenModeOn) {
Dmitry Titov 2011/11/30 01:35:53 '{' is not needed (and not balanced here). Since o
prasadt 2011/11/30 02:38:47 Done. And oops :-) I haven't yet compiled on mac.
+ [window setLevel:NSStatusWindowLevel];
+ else {
+ [window setLevel:NSNormalWindowLevel];
+}
+
- (BOOL)canBecomeKeyWindow {
// Panel can only gain focus if it is expanded. Minimized panels do not
// participate in Cmd-~ rotation.

Powered by Google App Engine
This is Rietveld 408576698