Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: chrome/browser/ui/panels/panel_browser_view.cc

Issue 8686012: Make panels not show on top when there is an app running in full screen mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge/Resolve. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/panels/panel_browser_view.h" 5 #include "chrome/browser/ui/panels/panel_browser_view.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "chrome/browser/ui/panels/panel.h" 9 #include "chrome/browser/ui/panels/panel.h"
10 #include "chrome/browser/ui/panels/panel_browser_frame_view.h" 10 #include "chrome/browser/ui/panels/panel_browser_frame_view.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 mouse_dragging_state_(NO_DRAGGING), 51 mouse_dragging_state_(NO_DRAGGING),
52 is_drawing_attention_(false), 52 is_drawing_attention_(false),
53 old_focused_view_(NULL) { 53 old_focused_view_(NULL) {
54 } 54 }
55 55
56 PanelBrowserView::~PanelBrowserView() { 56 PanelBrowserView::~PanelBrowserView() {
57 panel_->OnNativePanelClosed(); 57 panel_->OnNativePanelClosed();
58 } 58 }
59 59
60 void PanelBrowserView::Init() { 60 void PanelBrowserView::Init() {
61 if (!panel_->manager()->is_full_screen()) {
62 // TODO(prasadt): Implement this code.
63 // HideThePanel.
64 }
65
61 BrowserView::Init(); 66 BrowserView::Init();
62 67
63 GetWidget()->non_client_view()->SetAccessibleName( 68 GetWidget()->non_client_view()->SetAccessibleName(
64 l10n_util::GetStringUTF16(IDS_PRODUCT_NAME)); 69 l10n_util::GetStringUTF16(IDS_PRODUCT_NAME));
65 } 70 }
66 71
67 void PanelBrowserView::Close() { 72 void PanelBrowserView::Close() {
68 GetWidget()->RemoveObserver(this); 73 GetWidget()->RemoveObserver(this);
69 closed_ = true; 74 closed_ = true;
70 75
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 351
347 GetFrameView()->SchedulePaint(); 352 GetFrameView()->SchedulePaint();
348 } 353 }
349 354
350 bool PanelBrowserView::PreHandlePanelKeyboardEvent( 355 bool PanelBrowserView::PreHandlePanelKeyboardEvent(
351 const NativeWebKeyboardEvent& event, 356 const NativeWebKeyboardEvent& event,
352 bool* is_keyboard_shortcut) { 357 bool* is_keyboard_shortcut) {
353 return PreHandleKeyboardEvent(event, is_keyboard_shortcut); 358 return PreHandleKeyboardEvent(event, is_keyboard_shortcut);
354 } 359 }
355 360
361 void PanelBrowserView::FullScreenModeChanged(bool is_full_screen) {
362 // TODO(prasadt): Enable this code.
363 // if (is_full_screen)
364 // HideThePanel.
365 // else
366 // ShowThePanel.
367 }
368
356 void PanelBrowserView::HandlePanelKeyboardEvent( 369 void PanelBrowserView::HandlePanelKeyboardEvent(
357 const NativeWebKeyboardEvent& event) { 370 const NativeWebKeyboardEvent& event) {
358 HandleKeyboardEvent(event); 371 HandleKeyboardEvent(event);
359 } 372 }
360 373
361 gfx::Size PanelBrowserView::WindowSizeFromContentSize( 374 gfx::Size PanelBrowserView::WindowSizeFromContentSize(
362 const gfx::Size& content_size) const { 375 const gfx::Size& content_size) const {
363 gfx::Size frame = GetFrameView()->NonClientAreaSize(); 376 gfx::Size frame = GetFrameView()->NonClientAreaSize();
364 return gfx::Size(content_size.width() + frame.width(), 377 return gfx::Size(content_size.width() + frame.width(),
365 content_size.height() + frame.height()); 378 content_size.height() + frame.height());
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
573 } 586 }
574 587
575 bool NativePanelTestingWin::IsWindowSizeKnown() const { 588 bool NativePanelTestingWin::IsWindowSizeKnown() const {
576 return true; 589 return true;
577 } 590 }
578 591
579 bool NativePanelTestingWin::IsAnimatingBounds() const { 592 bool NativePanelTestingWin::IsAnimatingBounds() const {
580 return panel_browser_view_->bounds_animator_.get() && 593 return panel_browser_view_->bounds_animator_.get() &&
581 panel_browser_view_->bounds_animator_->is_animating(); 594 panel_browser_view_->bounds_animator_->is_animating();
582 } 595 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/panels/panel_browser_view.h ('k') | chrome/browser/ui/panels/panel_browser_window_cocoa.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698