Chromium Code Reviews

Unified Diff: content/renderer/renderer_gpu_video_decoder_factories.h

Issue 8686010: <video> decode in hardware! (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: scherkus CR#2 responses. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: content/renderer/renderer_gpu_video_decoder_factories.h
diff --git a/content/renderer/renderer_gpu_video_decoder_factories.h b/content/renderer/renderer_gpu_video_decoder_factories.h
new file mode 100644
index 0000000000000000000000000000000000000000..00dee38b1f26beb99b6fb216e50e67cefff98394
--- /dev/null
+++ b/content/renderer/renderer_gpu_video_decoder_factories.h
@@ -0,0 +1,48 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_RENDERER_RENDERER_GPU_VIDEO_DECODER_FACTORIES_H_
+#define CONTENT_RENDERER_RENDERER_GPU_VIDEO_DECODER_FACTORIES_H_
+#pragma once
+
+#include "base/basictypes.h"
+#include "base/memory/ref_counted.h"
+#include "base/memory/weak_ptr.h"
+#include "media/filters/gpu_video_decoder.h"
+#include "ui/gfx/size.h"
+
+class GpuChannelHost;
+class RendererGLContext;
+
+// Glue code to expose functionality needed by media::GpuVideoDecoder to
+// RenderViewImpl. This class is entirely an implementation detail of
+// RenderViewImpl and only has its own header to allow extraction of its
+// implementation from render_view_impl.cc which is already far too large.
+class RendererGpuVideoDecoderFactories :
scherkus (not reviewing) 2011/12/09 23:13:55 9 of 10 header files in chrome agree that colons g
+ public media::GpuVideoDecoder::Factories {
+ public:
+ virtual ~RendererGpuVideoDecoderFactories();
scherkus (not reviewing) 2011/12/09 23:13:55 don't we typically put dtors after ctors?
Ami GONE FROM CHROMIUM 2011/12/10 00:03:15 Chrome does (which is suboptimal in general but fi
+ // Takes a ref on |gpu_channel_host| and tests |context| for NULL before each
+ // use.
+ RendererGpuVideoDecoderFactories(GpuChannelHost* gpu_channel_host,
+ base::WeakPtr<RendererGLContext> context);
+
+ media::VideoDecodeAccelerator* CreateVideoDecodeAccelerator(
+ media::VideoDecodeAccelerator::Profile profile,
+ media::VideoDecodeAccelerator::Client* client) OVERRIDE;
+
+ virtual bool CreateTextures(int32 count, const gfx::Size& size,
+ std::vector<uint32>* texture_ids) OVERRIDE;
+
+ virtual bool DeleteTexture(uint32 texture_id) OVERRIDE;
+
+ virtual base::SharedMemory* CreateSharedMemory(size_t size) OVERRIDE;
+
+ private:
+ scoped_refptr<GpuChannelHost> gpu_channel_host_;
+ base::WeakPtr<RendererGLContext> context_;
+ DISALLOW_IMPLICIT_CONSTRUCTORS(RendererGpuVideoDecoderFactories);
+};
+
+#endif // CONTENT_RENDERER_RENDERER_GPU_VIDEO_DECODER_FACTORIES_H_

Powered by Google App Engine