<video> decode in hardware!

media/video/video_decode_accelerator.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_
 #define MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/callback_old.h"
 #include "media/base/bitstream_buffer.h"
+#include "media/base/video_decoder_config.h"
 #include "media/video/picture.h"
 #include "ui/gfx/size.h"
 
 namespace media {
 
 // Video decoder interface.
 // This interface is extended by the various components that ultimately
 // implement the backend of PPB_VideoDecode_Dev.
 //
 // No thread-safety guarantees are implied by the use of RefCountedThreadSafe
 // below.
 class MEDIA_EXPORT VideoDecodeAccelerator
     : public base::RefCountedThreadSafe<VideoDecodeAccelerator> {
  public:
-  // Video stream profile.  This *must* match PP_VideoDecoder_Profile.
-  enum Profile {
-    // Keep the values in this enum unique, as they imply format (h.264 vs. VP8,
-    // for example), and keep the values for a particular format grouped
-    // together for clarity.
-    H264PROFILE_MIN = 0,
-    H264PROFILE_BASELINE = H264PROFILE_MIN,
-    H264PROFILE_MAIN,
-    H264PROFILE_EXTENDED,
-    H264PROFILE_HIGH,
-    H264PROFILE_HIGH10PROFILE,
-    H264PROFILE_HIGH422PROFILE,
-    H264PROFILE_HIGH444PREDICTIVEPROFILE,
-    H264PROFILE_SCALABLEBASELINE,
-    H264PROFILE_SCALABLEHIGH,
-    H264PROFILE_STEREOHIGH,
-    H264PROFILE_MULTIVIEWHIGH,
-    H264PROFILE_MAX = H264PROFILE_MULTIVIEWHIGH,
-  };
+  typedef VideoCodecProfile Profile;

[scherkus (not reviewing), 2011/12/09 00:26:20]

grepping around I didn't find where the references are -- didn't you already
change the stuff in omx_video_decode_accelerator.cc?

[Ami GONE FROM CHROMIUM, 2011/12/09 22:55:50]

No; it's trickier; other mentions include: GVDA, GVDAH, gpu_messages (all easy).
 But then you run into ppapi impl and that's a whole 'nother mess of OWNERS and
I wanted to avoid that in this CL.
TODO'd instead.

 
   // Enumeration of potential errors generated by the API.
   // Note: Keep these in sync with PP_VideoDecodeError_Dev.
   enum Error {
     // An operation was attempted during an incompatible decoder state.
     ILLEGAL_STATE = 1,
     // Invalid argument was passed to an API method.
     INVALID_ARGUMENT,
     // Encoded input is unreadable.
     UNREADABLE_INPUT,
@@ skipping 96 matching lines @@
   virtual void Destroy() = 0;
 
  protected:
   friend class base::RefCountedThreadSafe<VideoDecodeAccelerator>;
   virtual ~VideoDecodeAccelerator();
 };
 
 }  // namespace media
 
 #endif  // MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_