Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: dbus/test_service.cc

Issue 8682032: Revert 111479 - chrome: dbus: support asynchronous method replies (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dbus/test_service.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dbus/test_service.cc
===================================================================
--- dbus/test_service.cc (revision 111486)
+++ dbus/test_service.cc (working copy)
@@ -13,8 +13,8 @@
namespace dbus {
-// Echo, SlowEcho, AsyncEcho, BrokenMethod.
-const int TestService::kNumMethodsToExport = 4;
+// Echo, SlowEcho, BrokenMethod.
+const int TestService::kNumMethodsToExport = 3;
TestService::Options::Options() {
}
@@ -148,15 +148,6 @@
exported_object_->ExportMethod(
"org.chromium.TestInterface",
- "AsyncEcho",
- base::Bind(&TestService::AsyncEcho,
- base::Unretained(this)),
- base::Bind(&TestService::OnExported,
- base::Unretained(this)));
- ++num_methods;
-
- exported_object_->ExportMethod(
- "org.chromium.TestInterface",
"BrokenMethod",
base::Bind(&TestService::BrokenMethod,
base::Unretained(this)),
@@ -172,44 +163,25 @@
message_loop->Run();
}
-void TestService::Echo(MethodCall* method_call,
- dbus::ExportedObject::ResponseSender response_sender) {
+Response* TestService::Echo(MethodCall* method_call) {
MessageReader reader(method_call);
std::string text_message;
- if (!reader.PopString(&text_message)) {
- response_sender.Run(NULL);
- return;
- }
+ if (!reader.PopString(&text_message))
+ return NULL;
Response* response = Response::FromMethodCall(method_call);
MessageWriter writer(response);
writer.AppendString(text_message);
- response_sender.Run(response);
+ return response;
}
-void TestService::SlowEcho(
- MethodCall* method_call,
- dbus::ExportedObject::ResponseSender response_sender) {
+Response* TestService::SlowEcho(MethodCall* method_call) {
base::PlatformThread::Sleep(TestTimeouts::tiny_timeout_ms());
- Echo(method_call, response_sender);
+ return Echo(method_call);
}
-void TestService::AsyncEcho(
- MethodCall* method_call,
- dbus::ExportedObject::ResponseSender response_sender) {
- // Schedule a call to Echo() to send an asynchronous response after we return.
- message_loop()->PostDelayedTask(FROM_HERE,
- base::Bind(&TestService::Echo,
- base::Unretained(this),
- method_call,
- response_sender),
- TestTimeouts::tiny_timeout_ms());
+Response* TestService::BrokenMethod(MethodCall* method_call) {
+ return NULL;
}
-void TestService::BrokenMethod(
- MethodCall* method_call,
- dbus::ExportedObject::ResponseSender response_sender) {
- response_sender.Run(NULL);
-}
-
} // namespace dbus
« no previous file with comments | « dbus/test_service.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698