Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3156)

Unified Diff: dbus/exported_object.h

Issue 8682032: Revert 111479 - chrome: dbus: support asynchronous method replies (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dbus/end_to_end_async_unittest.cc ('k') | dbus/exported_object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dbus/exported_object.h
===================================================================
--- dbus/exported_object.h (revision 111486)
+++ dbus/exported_object.h (working copy)
@@ -38,15 +38,9 @@
const std::string& service_name,
const std::string& object_path);
- // Called to send a response from an exported method. Response* is the
- // response message. Callers should pass a NULL Response* in the event
- // of an error that prevents the sending of a response.
- typedef base::Callback<void (Response*)> ResponseSender;
-
// Called when an exported method is called. MethodCall* is the request
- // message. ResponseSender is the callback that should be used to send a
- // response.
- typedef base::Callback<void (MethodCall*, ResponseSender)> MethodCallCallback;
+ // message.
+ typedef base::Callback<Response* (MethodCall*)> MethodCallCallback;
// Called when method exporting is done.
// Parameters:
@@ -130,14 +124,7 @@
MethodCall* method_call,
base::TimeTicks start_time);
- // Callback invoked by service provider to send a response to a method call.
- // Can be called immediately from a MethodCallCallback to implement a
- // synchronous service or called later to implement an asynchronous service.
- void SendResponse(base::TimeTicks start_time,
- MethodCall* method_call,
- Response* response);
-
- // Called on completion of the method run from SendResponse().
+ // Called on completion of the method run from RunMethod().
// Takes ownership of |method_call| and |response|.
void OnMethodCompleted(MethodCall* method_call,
Response* response,
« no previous file with comments | « dbus/end_to_end_async_unittest.cc ('k') | dbus/exported_object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698