Issue 8682032: Revert 111479 - chrome: dbus: support asynchronous method replies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8682032: Revert 111479 - chrome: dbus: support asynchronous method replies (Closed)

Created:
9 years, 1 month ago by Lei Zhang

Modified:
9 years, 1 month ago

Reviewers:
Vince Laviano

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 111479 - chrome: dbus: support asynchronous method replies BUG=chromium-os:23241 TEST=Unit tests and manual testing on device. Change-Id: I4d665897687030f4ab2379e4f6ddb9b3ebe02af4 Review URL: http://codereview.chromium.org/8637002 TBR=vlaviano@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111487

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -135 lines)			Patch
M	chrome/browser/chromeos/dbus/proxy_resolution_service_provider.h	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/dbus/proxy_resolution_service_provider.cc	View	3 chunks	+8 lines, -12 lines	0 comments	Download
M	dbus/bus.h	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	dbus/end_to_end_async_unittest.cc	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	dbus/exported_object.h	View	2 chunks	+3 lines, -16 lines	0 comments	Download
M	dbus/exported_object.cc	View	2 chunks	+13 lines, -27 lines	0 comments	Download
M	dbus/test_service.h	View	3 chunks	+4 lines, -12 lines	0 comments	Download
M	dbus/test_service.cc	View	3 chunks	+10 lines, -38 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

9 years, 1 month ago (2011-11-24 03:03:24 UTC) #2

Broke cros bots... the ones you are sheriffing:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS/bui...
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20Clang%20%28C...

Expand Messages | Collapse Messages