Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 8682030: Revert "Increase Bind/Callback Arity from 6 -> 11: These go to eleven." (Closed)

Created:
9 years, 1 month ago by awong
Modified:
9 years, 1 month ago
CC:
chromium-reviews, brettw-cc_chromium.org, James Hawkins
Visibility:
Public.

Description

Revert "Increase Bind/Callback Arity from 6 -> 11: These go to eleven." This reverts r111410. Doing this increased Win builder cycle time by about 10s on incrementals (eyeballed from stats dashboard). Alas, 11 proved to be too high for us. BUG=98542 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -5110 lines) Patch
M base/bind.h View 1 chunk +0 lines, -438 lines 0 comments Download
M base/bind.h.pump View 1 chunk +1 line, -1 line 0 comments Download
M base/bind_internal.h View 35 chunks +318 lines, -4041 lines 0 comments Download
M base/bind_internal.h.pump View 1 chunk +1 line, -1 line 0 comments Download
M base/bind_internal_win.h View 1 chunk +0 lines, -285 lines 0 comments Download
M base/bind_internal_win.h.pump View 1 chunk +1 line, -1 line 0 comments Download
M base/callback.h View 2 chunks +1 line, -342 lines 0 comments Download
M base/callback.h.pump View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
awong
9 years, 1 month ago (2011-11-24 00:58:36 UTC) #1
willchan no longer on Chromium
9 years, 1 month ago (2011-11-24 01:01:59 UTC) #2
LGTM

On Wed, Nov 23, 2011 at 4:58 PM, <ajwong@chromium.org> wrote:

> Reviewers: willchan,
>
> Description:
> Revert "Increase Bind/Callback Arity from 6 -> 11: These to eleven."
>
> This reverts r111410.
>
> Doing this increased Win builder cycle time by about 10s on incrementals
> (eyeballed from stats dashboard).  Alas, 11 proved to be too high for
> us.
>
> BUG=98542
> TEST=none
>
>
> Please review this at
http://codereview.chromium.**org/8682030/<http://codereview.chromium.org/8682...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M base/bind.h
>  M base/bind.h.pump
>  M base/bind_internal.h
>  M base/bind_internal.h.pump
>  M base/bind_internal_win.h
>  M base/bind_internal_win.h.pump
>  M base/callback.h
>  M base/callback.h.pump
>
>
>

Powered by Google App Engine
This is Rietveld 408576698