Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 8682028: CrOS: Remove a DCHECK causing test failures in DBus on Aura (Closed)

Created:
9 years, 1 month ago by James Cook
Modified:
9 years, 1 month ago
Reviewers:
satorux1
CC:
chromium-reviews
Visibility:
Public.

Description

CrOS: Remove a DCHECK causing test failures in DBus on Aura The tests run fine without this check, and we've filed a bug to investigate further. BUG=chromium-os:23416 TEST=browser_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111498

Patch Set 1 #

Total comments: 1

Patch Set 2 : whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M dbus/bus.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
James Cook
Satoru, PTAL.
9 years, 1 month ago (2011-11-24 00:17:22 UTC) #1
satorux1
LGTM http://codereview.chromium.org/8682028/diff/1/dbus/bus.cc File dbus/bus.cc (right): http://codereview.chromium.org/8682028/diff/1/dbus/bus.cc#newcode206 dbus/bus.cc:206: //DCHECK_EQ(0, num_pending_timeouts_); I hate to say, but a ...
9 years, 1 month ago (2011-11-24 00:44:34 UTC) #2
James Cook
On 2011/11/24 00:44:34, satorux1 wrote: > LGTM > > http://codereview.chromium.org/8682028/diff/1/dbus/bus.cc > File dbus/bus.cc (right): > ...
9 years, 1 month ago (2011-11-24 00:46:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/8682028/2003
9 years, 1 month ago (2011-11-24 00:46:48 UTC) #4
commit-bot: I haz the power
Try job failure for 8682028-2003 (retry) on win_rel for step "ui_tests". It's a second try, ...
9 years, 1 month ago (2011-11-24 02:48:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/8682028/2003
9 years, 1 month ago (2011-11-24 04:21:51 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-11-24 07:00:45 UTC) #7
Change committed as 111498

Powered by Google App Engine
This is Rietveld 408576698