Issue 8682027: Add TraceAnalyzer support for START/FINISH events and JSON error logging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8682027: Add TraceAnalyzer support for START/FINISH events and JSON error logging (Closed)

Created:
9 years, 1 month ago by jbates

Modified:
9 years ago

Reviewers:
nduca, Paweł Hajdan Jr.

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add TraceAnalyzer support for START/FINISH events and JSON error logging Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112723

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+136 lines, -40 lines)			Patch
M	base/test/trace_event_analyzer.h	View	5 chunks	+16 lines, -2 lines	0 comments	Download
M	base/test/trace_event_analyzer.cc	View	4 chunks	+82 lines, -37 lines	0 comments	Download
M	base/test/trace_event_analyzer_unittest.cc	View	9 chunks	+38 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbates@chromium.org/8682027/1

9 years ago (2011-11-30 22:15:58 UTC) #3

commit-bot: I haz the power

Can't apply patch for file base/test/trace_event_analyzer.cc. While running patch -p1 --forward --force; patching file base/test/trace_event_analyzer.cc ...

9 years ago (2011-11-30 22:15:59 UTC) #4

LGTM

Expand Messages | Collapse Messages