Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Issue 8682024: Allow override of default target. Check if target should not be in all. (Closed)

Created:
9 years, 1 month ago by John Grabowski
Modified:
9 years, 1 month ago
Reviewers:
Mark Mentovai, Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Allow override of default target. Check if target should not be in all.

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M pylib/gyp/generator/make.py View 1 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
John Grabowski
9 years, 1 month ago (2011-11-23 21:49:42 UTC) #1
Mark Mentovai
Nico has been working on the make generator, I’ll defer to him.
9 years, 1 month ago (2011-11-23 21:57:43 UTC) #2
Nico
Since it's two unrelated changes, can you break this up into two CLs? Let's say ...
9 years, 1 month ago (2011-11-23 22:53:40 UTC) #3
John Grabowski
On 2011/11/23 22:53:40, Nico wrote: > Since it's two unrelated changes, can you break this ...
9 years, 1 month ago (2011-11-23 23:06:43 UTC) #4
Nico
> Can you throw me a bone here? > This all falls under 'All/all' work. ...
9 years, 1 month ago (2011-11-23 23:09:24 UTC) #5
John Grabowski
On 2011/11/23 23:09:24, Nico wrote: > > Can you throw me a bone here? > ...
9 years, 1 month ago (2011-11-23 23:23:05 UTC) #6
John Grabowski
On 2011/11/23 23:23:05, John Grabowski wrote: > On 2011/11/23 23:09:24, Nico wrote: > > > ...
9 years, 1 month ago (2011-11-23 23:46:39 UTC) #7
Nico
9 years, 1 month ago (2011-11-23 23:47:36 UTC) #8
LGTM; please update cl description before landing.

Powered by Google App Engine
This is Rietveld 408576698