Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 8682015: Increase Bind/Callback Arity from 6 -> 11: These go to eleven. (Closed)

Created:
9 years, 1 month ago by awong
Modified:
9 years, 1 month ago
CC:
chromium-reviews, brettw-cc_chromium.org, groby-ooo-7-16
Visibility:
Public.

Description

Increase Bind/Callback Arity from 6 -> 11: These go to eleven. This is only for a build time stress test only. I will revert back to 6 after getting the data. 11 allows for binding of 11 arguments to a function, and 10 arguments to a method. 10 seemed like a nice round number to try (MSVC's tr1::bind() only supports 10). Template Growth rate (n == arity): bind.h: n bind_internal.h: (n^2 + 20n)/2 bind_internal_win.h: n callback.h: n Template growth equation: (n^2 + 26n) / 2 Template growth: 96 -> 203 types BUG=98542 TEST=try bots. Then we get to watch the bot cycle times. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111410

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5113 lines, -326 lines) Patch
M base/bind.h View 1 chunk +438 lines, -0 lines 0 comments Download
M base/bind.h.pump View 1 chunk +1 line, -1 line 0 comments Download
M base/bind_internal.h View 35 chunks +4044 lines, -321 lines 0 comments Download
M base/bind_internal.h.pump View 1 chunk +1 line, -1 line 0 comments Download
M base/bind_internal_win.h View 1 chunk +285 lines, -0 lines 0 comments Download
M base/bind_internal_win.h.pump View 1 chunk +1 line, -1 line 0 comments Download
M base/callback.h View 2 chunks +342 lines, -1 line 0 comments Download
M base/callback.h.pump View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
awong
I could choose a lower target if this sounds scary. But I figured it's just ...
9 years, 1 month ago (2011-11-23 18:26:27 UTC) #1
James Hawkins
Let's try this to get numbers then back off to at most 7, though could ...
9 years, 1 month ago (2011-11-23 18:31:45 UTC) #2
James Hawkins
LGTM
9 years, 1 month ago (2011-11-23 18:32:52 UTC) #3
willchan no longer on Chromium
I'm in favor of backing off to 7, but if you just want to gather ...
9 years, 1 month ago (2011-11-23 18:54:25 UTC) #4
awong
9 years, 1 month ago (2011-11-23 18:56:25 UTC) #5
Cool. I've updated the comment to say we're going to revert this.

On 2011/11/23 18:54:25, willchan wrote:
> I'm in favor of backing off to 7, but if you just want to gather data first,
> then I'm fine with 11. But I think long-term we don't want people to be
> Bind()'ing that many arguments.
> LGTM.

Powered by Google App Engine
This is Rietveld 408576698