Moving the MHTML API out of experimental and renaming it.

Moving the MHTML API out of experimental and renaming it.

Moving the savePageAsMTML API out of experimental and renaming it per Kathy
suggestion to pageCapture.saveAsMhtml.

BUG=None
TEST=The API should still work.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111678

[asargent_no_longer_on_chrome, 2011-11-23 19:57:34]

lgtm

[Aaron Boodman, 2011-11-23 22:24:48]

http://codereview.chromium.org/8682013/diff/1/chrome/common/extensions/api/ex...
File chrome/common/extensions/api/extension_api.json (right):

http://codereview.chromium.org/8682013/diff/1/chrome/common/extensions/api/ex...
chrome/common/extensions/api/extension_api.json:9063: "name": "saveAsMhtml",
I think it is better all caps. I guess you got advice to the contrary?

[jcivelli, 2011-11-23 22:41:30]

http://codereview.chromium.org/8682013/diff/1/chrome/common/extensions/api/ex...
File chrome/common/extensions/api/extension_api.json (right):

http://codereview.chromium.org/8682013/diff/1/chrome/common/extensions/api/ex...
chrome/common/extensions/api/extension_api.json:9063: "name": "saveAsMhtml",
On 2011/11/23 22:24:49, Aaron Boodman wrote:
> I think it is better all caps. I guess you got advice to the contrary?
Yes, here is what Kathy said:
" saveAsMHTML uses unusual capitalization. Usually we'd use saveAsMhtml.
  (Actually, we're inconsistent -- e.g., we have both getURL and addUrl -- but
we use lowercase more often, and it seems more right to me.)"

[Aaron Boodman, 2011-11-23 22:45:23]

On 2011/11/23 22:41:30, jcivelli wrote:
>
http://codereview.chromium.org/8682013/diff/1/chrome/common/extensions/api/ex...
> File chrome/common/extensions/api/extension_api.json (right):
> 
>
http://codereview.chromium.org/8682013/diff/1/chrome/common/extensions/api/ex...
> chrome/common/extensions/api/extension_api.json:9063: "name": "saveAsMhtml",
> On 2011/11/23 22:24:49, Aaron Boodman wrote:
> > I think it is better all caps. I guess you got advice to the contrary?
> Yes, here is what Kathy said:
> " saveAsMHTML uses unusual capitalization. Usually we'd use saveAsMhtml.
>   (Actually, we're inconsistent -- e.g., we have both getURL and addUrl -- but
> we use lowercase more often, and it seems more right to me.)"

Heh, I was planning on steering us more toward URL, ID, etc. That is what we do
more often in Chrome's source code, and it looks more right to me.

We should obviously decide. You have my vote. Kathy?

[Aaron Boodman, 2011-11-23 22:45:49]

+kathy

[kathyw, 2011-11-24 00:40:13]

I'm not religious about this... saveAsMHTML looks ugly/shouty to me,
but as long as we're consistent from here on out, I think we're fine.

-k-

On Wed, Nov 23, 2011 at 2:45 PM,  <aa@chromium.org> wrote:
> +kathy
>
> http://codereview.chromium.org/8682013/
>

[Aaron Boodman, 2011-11-24 03:16:50]

On Wed, Nov 23, 2011 at 4:40 PM, Kathy Walrath <kathyw@chromium.org> wrote:
> I'm not religious about this... saveAsMHTML looks ugly/shouty to me,
> but as long as we're consistent from here on out, I think we're fine.

I can see that, especially for this case. But things like Xml and Url
look really unprofessional to me because they are well-known acronyms
that are never written in mixed case.

Please go with MHTML. I'll try and find time to make aliases for the
old bad examples sometime soon.

Thanks,

- a

[Jay Civelli, 2011-11-25 18:53:11]

On 2011/11/24 03:16:50, Aaron Boodman wrote:
> On Wed, Nov 23, 2011 at 4:40 PM, Kathy Walrath <mailto:kathyw@chromium.org>
wrote:
> > I'm not religious about this... saveAsMHTML looks ugly/shouty to me,
> > but as long as we're consistent from here on out, I think we're fine.
> 
> I can see that, especially for this case. But things like Xml and Url
> look really unprofessional to me because they are well-known acronyms
> that are never written in mixed case.
> 
> Please go with MHTML. I'll try and find time to make aliases for the
> old bad examples sometime soon.
> 
> Thanks,
> 
> - a

OK, renamed to saveAsMHTML.

Jay

[Aaron Boodman, 2011-11-27 06:17:33]

Thanks, LGTM

[commit-bot: I haz the power, 2011-11-27 23:43:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jcivelli@chromium.org/8682013/8001

[commit-bot: I haz the power, 2011-11-27 23:43:09]

Failed to request the patch to try. Please note that binary filesare still
unsupported at the moment, this is being worked on.

Thanks for your patience.

HTTP Error 302: Found

[kathyw, 2011-11-28 19:11:23]

Just to give a little historical background...

The reason Xml and Url are capitalized that way in many APIs probably
has its roots in the Java style guidelines.
http://en.wikipedia.org/wiki/Naming_convention_(programming) lists
some of the important naming rules, such as "Initialisms of three or
more letters are CamelCase instead of upper case (e.g.,
"parseDbmXmlFromIPAddress" instead of "parseDBMXMLFromIPAddress"). One
may also set the boundary at two or more letters (e.g.,
"parseDbmXmlFromIpAddress")."

I think we decided on that convention for readability's sake. Mixed
case is just easier to read. Plus upper case tends to make things look
like constants.

JavaScript usually follows the Java naming guidelines, but not always
(e.g. getElementById, getElementsByTagNameNS, and the bipolar
XMLHttpRequest).

-k-

On Wed, Nov 23, 2011 at 7:16 PM, Aaron Boodman <aa@chromium.org> wrote:
>
> On Wed, Nov 23, 2011 at 4:40 PM, Kathy Walrath <kathyw@chromium.org> wrote:
> > I'm not religious about this... saveAsMHTML looks ugly/shouty to me,
> > but as long as we're consistent from here on out, I think we're fine.
>
> I can see that, especially for this case. But things like Xml and Url
> look really unprofessional to me because they are well-known acronyms
> that are never written in mixed case.
>
> Please go with MHTML. I'll try and find time to make aliases for the
> old bad examples sometime soon.
>
> Thanks,
>
> - a