Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 8682011: views: Move combobox directory to ui/views/controls/. (Closed)

Created:
9 years, 1 month ago by tfarina
Modified:
9 years, 1 month ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, Paweł Hajdan Jr., stevenjb+watch_chromium.org, davemoore+watch_chromium.org, dhollowa
Visibility:
Public.

Description

views: Move combobox directory to ui/views/controls/. BUG=104039 R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111478

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -1628 lines) Patch
M chrome/browser/chromeos/options/vpn_config_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/cookie_info_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/cookie_info_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/uninstall_view.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/views/controls/combobox/combobox.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/views/controls/combobox/combobox.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/views/controls/combobox/combobox_listener.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/views/controls/combobox/native_combobox_gtk.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/views/controls/combobox/native_combobox_gtk.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/views/controls/combobox/native_combobox_views.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/views/controls/combobox/native_combobox_views.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + ui/views/controls/combobox/native_combobox_views_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/views/controls/combobox/native_combobox_win.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/views/controls/combobox/native_combobox_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/views/controls/combobox/native_combobox_wrapper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/examples/combobox_example.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/combobox_example.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/native_theme_button_example.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/native_theme_button_example.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/text_example.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/text_example.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/focus/focus_traversal_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D views/controls/combobox/combobox.h View 1 chunk +0 lines, -102 lines 0 comments Download
D views/controls/combobox/combobox.cc View 1 chunk +0 lines, -143 lines 0 comments Download
D views/controls/combobox/combobox_listener.h View 1 chunk +0 lines, -28 lines 0 comments Download
D views/controls/combobox/native_combobox_gtk.h View 1 chunk +0 lines, -64 lines 0 comments Download
D views/controls/combobox/native_combobox_gtk.cc View 1 chunk +0 lines, -228 lines 0 comments Download
D views/controls/combobox/native_combobox_views.h View 1 chunk +0 lines, -104 lines 0 comments Download
D views/controls/combobox/native_combobox_views.cc View 1 chunk +0 lines, -386 lines 0 comments Download
D views/controls/combobox/native_combobox_views_unittest.cc View 1 chunk +0 lines, -166 lines 0 comments Download
D views/controls/combobox/native_combobox_win.h View 1 chunk +0 lines, -58 lines 0 comments Download
D views/controls/combobox/native_combobox_win.cc View 1 chunk +0 lines, -215 lines 0 comments Download
D views/controls/combobox/native_combobox_wrapper.h View 1 chunk +0 lines, -71 lines 0 comments Download
M views/controls/native_control_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/views.gyp View 5 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
9 years, 1 month ago (2011-11-23 16:33:22 UTC) #1
Ben Goodger (Google)
9 years, 1 month ago (2011-11-24 01:28:53 UTC) #2
LGTM

On Wed, Nov 23, 2011 at 8:33 AM, <tfarina@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> views: Move combobox directory to ui/views/controls/.
>
> BUG=104039
> R=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/8682011/<http://codereview.chromium.org/8682...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/chromeos/**options/vpn_config_view.h
>  M chrome/browser/chromeos/**options/vpn_config_view.cc
>  M chrome/browser/chromeos/**options/wifi_config_view.h
>  M chrome/browser/chromeos/**options/wifi_config_view.cc
>  M chrome/browser/ui/views/**bookmarks/bookmark_bubble_**view.h
>  M chrome/browser/ui/views/**bookmarks/bookmark_bubble_**view.cc
>  M chrome/browser/ui/views/**cookie_info_view.h
>  M chrome/browser/ui/views/**cookie_info_view.cc
>  M chrome/browser/ui/views/**uninstall_view.cc
>  A + ui/views/controls/combobox/**combobox.h
>  A + ui/views/controls/combobox/**combobox.cc
>  A + ui/views/controls/combobox/**combobox_listener.h
>  A + ui/views/controls/combobox/**native_combobox_gtk.h
>  A + ui/views/controls/combobox/**native_combobox_gtk.cc
>  A + ui/views/controls/combobox/**native_combobox_views.h
>  A + ui/views/controls/combobox/**native_combobox_views.cc
>  A + ui/views/controls/combobox/**native_combobox_views_**unittest.cc
>  A + ui/views/controls/combobox/**native_combobox_win.h
>  A + ui/views/controls/combobox/**native_combobox_win.cc
>  A + ui/views/controls/combobox/**native_combobox_wrapper.h
>  M ui/views/examples/combobox_**example.h
>  M ui/views/examples/combobox_**example.cc
>  M ui/views/examples/native_**theme_button_example.h
>  M ui/views/examples/native_**theme_button_example.cc
>  M ui/views/examples/text_**example.h
>  M ui/views/examples/text_**example.cc
>  M ui/views/focus/focus_**traversal_unittest.cc
>  D views/controls/combobox/**combobox.h
>  D views/controls/combobox/**combobox.cc
>  D views/controls/combobox/**combobox_listener.h
>  D views/controls/combobox/**native_combobox_gtk.h
>  D views/controls/combobox/**native_combobox_gtk.cc
>  D views/controls/combobox/**native_combobox_views.h
>  D views/controls/combobox/**native_combobox_views.cc
>  D views/controls/combobox/**native_combobox_views_**unittest.cc
>  D views/controls/combobox/**native_combobox_win.h
>  D views/controls/combobox/**native_combobox_win.cc
>  D views/controls/combobox/**native_combobox_wrapper.h
>  M views/controls/native_control_**win.cc
>  M views/views.gyp
>
>
>

Powered by Google App Engine
This is Rietveld 408576698