Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Unified Diff: content/browser/device_orientation/provider_unittest.cc

Issue 8682001: Disable DeviceOrientationproviderTest.ObserverNotRemoved on Linux (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: FLAKY_ -> MAYBE_ Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/device_orientation/provider_unittest.cc
diff --git a/content/browser/device_orientation/provider_unittest.cc b/content/browser/device_orientation/provider_unittest.cc
index 57fbbfe0cdb095ee5b254b71b5512b05428ca281..a705ed66fd1408661a16d4b7b096191ec1c2663e 100644
--- a/content/browser/device_orientation/provider_unittest.cc
+++ b/content/browser/device_orientation/provider_unittest.cc
@@ -248,8 +248,13 @@ TEST_F(DeviceOrientationProviderTest, MultipleObserversPushTest) {
provider_->RemoveObserver(checker_c.get());
}
-// Flaky. See crbug.com/104950.
-TEST_F(DeviceOrientationProviderTest, FLAKY_ObserverNotRemoved) {
+#if defined(OS_LINUX)
+// Flakily DCHECKs on Linux. See crbug.com/104950.
+#define MAYBE_ObserverNotRemoved DISABLED_ObserverNotRemoved
+#else
+#define MAYBE_ObserverNotRemoved ObserverNotRemoved
+#endif
+TEST_F(DeviceOrientationProviderTest, MAYBE_ObserverNotRemoved) {
scoped_refptr<MockOrientationFactory> orientation_factory(
new MockOrientationFactory());
Init(MockOrientationFactory::CreateDataFetcher);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698