content/browser/device_orientation/provider_unittest.cc - Issue 8682001: Disable DeviceOrientationproviderTest.ObserverNotRemoved on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/device_orientation/provider_unittest.cc

Issue 8682001: Disable DeviceOrientationproviderTest.ObserverNotRemoved on Linux (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/device_orientation/provider_unittest.cc

diff --git a/content/browser/device_orientation/provider_unittest.cc b/content/browser/device_orientation/provider_unittest.cc

index 57fbbfe0cdb095ee5b254b71b5512b05428ca281..a180c05930311bf307411faaaad9c13817afdb86 100644

--- a/content/browser/device_orientation/provider_unittest.cc

+++ b/content/browser/device_orientation/provider_unittest.cc

@@ -248,7 +248,12 @@ TEST_F(DeviceOrientationProviderTest, MultipleObserversPushTest) {

provider_->RemoveObserver(checker_c.get());

}

-// Flaky. See crbug.com/104950.

+#if defined(OS_LINUX)

+// Flakily DCHECKs on Linux. See crbug.com/104950.

+#define MAYBE_ObserverNotRemoved DISABLED_ObserverNotRemoved

+#else

+#define MAYBE_ObserverNotRemoved ObserverNotRemoved

+#endif

TEST_F(DeviceOrientationProviderTest, FLAKY_ObserverNotRemoved) {

yosin_UTC9 2011/11/23 07:21:17 s/FLAKY_/MAYBE_/

scoped_refptr<MockOrientationFactory> orientation_factory(

new MockOrientationFactory());

« no previous file with comments | « no previous file | no next file » | no next file with comments »