Issue 8682001: Disable DeviceOrientationproviderTest.ObserverNotRemoved on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8682001: Disable DeviceOrientationproviderTest.ObserverNotRemoved on Linux (Closed)

Created:
9 years, 1 month ago by Ryan Sleevi

Modified:
9 years, 1 month ago

Reviewers:
yosin

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disable DeviceOrientationproviderTest.ObserverNotRemoved on Linux BUG=104950 TBR=hans@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111326

Patch Set 1 #

Total comments: 1

Patch Set 2 : FLAKY_ -> MAYBE_ #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	content/browser/device_orientation/provider_unittest.cc	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

hans: TBR. It needs to be marked DISABLED_ because it crashes. FLAKY_ only covers if ...

9 years, 1 month ago (2011-11-23 07:20:08 UTC) #1

yosin_UTC9

9 years, 1 month ago (2011-11-23 07:21:17 UTC) #3

Please ignore.

http://codereview.chromium.org/8682001/diff/1/content/browser/device_orientat...
File content/browser/device_orientation/provider_unittest.cc (right):

http://codereview.chromium.org/8682001/diff/1/content/browser/device_orientat...
content/browser/device_orientation/provider_unittest.cc:257:
TEST_F(DeviceOrientationProviderTest, FLAKY_ObserverNotRemoved) {
s/FLAKY_/MAYBE_/

Expand Messages | Collapse Messages