[cros] Make disconnected icons used by network drop-down and network button consistent.

chrome/browser/resources/chromeos/login/network_dropdown.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Network drop-down implementation.
  */
 
 cr.define('cr.ui', function() {
   /**
@@ skipping 351 matching lines @@
    * Updates network title, which is shown by the drop-down.
    * @param {string} title Title to be displayed.
    * @param {!Object} icon Icon to be displayed.
    */
   DropDown.updateNetworkTitle = function(title, icon) {
     if (DropDown.activeElementId_)
       $(DropDown.activeElementId_).setTitle(title, icon);
   };
 
   /**
-   * Activates or deactivates network drop-down. Only one network drop-down
+   * Activates network drop-down. Only one network drop-down
    * can be active at the same time. So activating new drop-down deactivates
-   * the previous one. Deactivating not active drop-down does nothing.
+   * the previous one.
    * @param {string} element_id Id of the element which is network drop-down.

[whywhat, 2011/11/29 07:58:06]

Should be named "elementId"
Would "Id of network drop-down element" be a better description?

[altimofeev, 2011/11/29 17:10:46]

Done.

-   * @param {boolean} isActive Is drop-down active?
-   * @param {boolean} isOobe Is dropdown placed on an OOBE screen.
+   * @param {boolean} isOobe Whether drop-down is used by an Oobe screen.
+   * @param {integer} last Last active network type.

[whywhat, 2011/11/29 07:58:06]

Could you rename it to smth less general? i.e. lastNetworkType or
lastActiveNetwork?
Also add a comment about -1 as a special value that you use in the next file

[altimofeev, 2011/11/29 17:10:46]

Done.

    */
-  DropDown.setActive = function(elementId, isActive, isOobe) {
-    if (isActive) {
-      $(elementId).isShown = false;
-      if (DropDown.activeElementId_ != elementId) {
-        DropDown.activeElementId_ = elementId;
-        chrome.send('networkDropdownShow', [elementId, isOobe]);
-      }
-    } else {
-      if (DropDown.activeElementId_ == elementId) {
-        DropDown.activeElementId_ = '';
-        chrome.send('networkDropdownHide', []);
-      }
+  DropDown.show = function(elementId, isOobe, last) {
+    $(elementId).isShown = false;
+    if (DropDown.activeElementId_ != elementId) {
+      DropDown.activeElementId_ = elementId;
+      chrome.send('networkDropdownShow', [elementId, isOobe, last]);
     }
   };
 
+  /**
+   * Deactivates network drop-down. Deactivating not active drop-down does

[whywhat, 2011/11/29 07:58:06]

not active -> inactive

[altimofeev, 2011/11/29 17:10:46]

Done.

+   * nothing.
+   * @param {string} element_id Id of the element which is network drop-down.

[whywhat, 2011/11/29 07:58:06]

Ditto about comment and name

[altimofeev, 2011/11/29 17:10:46]

Done.

+   */
+  DropDown.hide = function(elementId) {
+    if (DropDown.activeElementId_ == elementId) {
+      DropDown.activeElementId_ = '';
+      chrome.send('networkDropdownHide', []);

[whywhat, 2011/11/29 07:58:06]

nit: I thought you don't need to specify [] explicitly, though I could be wrong
:)

[altimofeev, 2011/11/29 17:10:46]

You are right, they are not obligatory. But I think usage of '[]' is consistent
with the fact, that C++ handler anyway has ListValue argument.

+    }
+  };
+
   /**
    * Refreshes network drop-down. Should be called on language change.
    */
   DropDown.refresh = function() {
     chrome.send('networkDropdownRefresh', []);
   };
 
   return {
     DropDown: DropDown
   };
 });