Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc

Issue 8681029: [cros] Make disconnected icons used by network drop-down and network button consistent. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merged Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.h" 5 #include "chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/values.h"
10 #include "chrome/browser/chromeos/cros/network_library.h"
9 #include "chrome/browser/chromeos/login/webui_login_display.h" 11 #include "chrome/browser/chromeos/login/webui_login_display.h"
10 #include "chrome/browser/ui/webui/chromeos/login/network_dropdown.h" 12 #include "chrome/browser/ui/webui/chromeos/login/network_dropdown.h"
11 #include "content/browser/webui/web_ui.h" 13 #include "content/browser/webui/web_ui.h"
12 #include "grit/generated_resources.h" 14 #include "grit/generated_resources.h"
13 #include "ui/base/l10n/l10n_util.h" 15 #include "ui/base/l10n/l10n_util.h"
14 16
15 namespace { 17 namespace {
16 18
17 // JS API callbacks names. 19 // JS API callbacks names.
18 const char kJsApiNetworkItemChosen[] = "networkItemChosen"; 20 const char kJsApiNetworkItemChosen[] = "networkItemChosen";
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 DCHECK(args->GetSize() == 1); 61 DCHECK(args->GetSize() == 1);
60 double id; 62 double id;
61 if (!args->GetDouble(0, &id)) 63 if (!args->GetDouble(0, &id))
62 NOTREACHED(); 64 NOTREACHED();
63 DCHECK(dropdown_.get()); 65 DCHECK(dropdown_.get());
64 dropdown_->OnItemChosen(static_cast<int>(id)); 66 dropdown_->OnItemChosen(static_cast<int>(id));
65 } 67 }
66 68
67 void NetworkDropdownHandler::HandleNetworkDropdownShow( 69 void NetworkDropdownHandler::HandleNetworkDropdownShow(
68 const base::ListValue* args) { 70 const base::ListValue* args) {
69 DCHECK(args->GetSize() == 2); 71 DCHECK(args->GetSize() == 3);
70 std::string element_id; 72 std::string element_id;
71 if (!args->GetString(0, &element_id)) 73 if (!args->GetString(0, &element_id))
72 NOTREACHED(); 74 NOTREACHED();
73 bool oobe; 75 bool oobe;
74 if (!args->GetBoolean(1, &oobe)) 76 if (!args->GetBoolean(1, &oobe))
75 NOTREACHED(); 77 NOTREACHED();
76 78
79
80 double last_network_type = -1; // Javascript passes integer as double.
81 if (!args->GetDouble(2, &last_network_type))
82 NOTREACHED();
83
77 dropdown_.reset(new NetworkDropdown(web_ui_, GetNativeWindow(), oobe)); 84 dropdown_.reset(new NetworkDropdown(web_ui_, GetNativeWindow(), oobe));
85
86 if (last_network_type >= 0) {
87 dropdown_->SetLastNetworkType(
88 static_cast<ConnectionType>(last_network_type));
89 }
78 } 90 }
79 91
80 void NetworkDropdownHandler::HandleNetworkDropdownHide( 92 void NetworkDropdownHandler::HandleNetworkDropdownHide(
81 const base::ListValue* args) { 93 const base::ListValue* args) {
82 DCHECK(args->GetSize() == 0); 94 DCHECK(args->GetSize() == 0);
83 dropdown_.reset(); 95 dropdown_.reset();
84 } 96 }
85 97
86 void NetworkDropdownHandler::HandleNetworkDropdownRefresh( 98 void NetworkDropdownHandler::HandleNetworkDropdownRefresh(
87 const base::ListValue* args) { 99 const base::ListValue* args) {
88 DCHECK(args->GetSize() == 0); 100 DCHECK(args->GetSize() == 0);
89 // Since language change is async, 101 // Since language change is async,
90 // we may in theory be on another screen during this call. 102 // we may in theory be on another screen during this call.
91 if (dropdown_.get()) 103 if (dropdown_.get())
92 dropdown_->Refresh(); 104 dropdown_->Refresh();
93 } 105 }
94 106
95 } // namespace chromeos 107 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698