Issue 8681027: Fix bug 578

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8681027: Fix bug 578 (Closed)

Created:
9 years, 1 month ago by jimhug

Modified:
9 years, 1 month ago

Reviewers:
ahe, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix bug 578 implements generic factory methods and adds all the requisite machinery to consider any member a generic scope Now that frog selfhost is warning free, enable --warnings_as_errors in presubmit to keep it that way. BUG=578 TEST=frog selhost Committed: https://code.google.com/p/dart/source/detail?r=1831

Patch Set 1 #

Patch Set 2 : prereviewed #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1238 lines, -1237 lines)			Patch
A	frog/element.dart	View		1 chunk	+129 lines, -0 lines	0 comments	Download
M	frog/evaluator.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	frog/frogsh	View	1	256 chunks	+915 lines, -940 lines	0 comments	Download
M	frog/gen.dart	View		5 chunks	+6 lines, -5 lines	0 comments	Download
M	frog/lang.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	frog/leg/util/link_implementation.dart	View		1 chunk	+4 lines, -6 lines	0 comments	Download
M	frog/library.dart	View		8 chunks	+51 lines, -20 lines	0 comments	Download
M	frog/member.dart	View	1	20 chunks	+51 lines, -99 lines	0 comments	Download
M	frog/parser.dart	View		13 chunks	+26 lines, -19 lines	0 comments	Download
M	frog/presubmit.py	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	frog/scripts/tree_gen.py	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	frog/tree.g.dart	View	1	4 chunks	+5 lines, -3 lines	0 comments	Download
M	frog/type.dart	View		18 chunks	+30 lines, -126 lines	0 comments	Download
M	frog/world.dart	View		3 chunks	+12 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

9 years, 1 month ago (2011-11-25 00:03:18 UTC) #3

On 2011/11/24 08:41:24, ahe wrote:
> Changes to link_implementation.dart LGTM.

lgtm! really like the unification that happened in Element

Expand Messages | Collapse Messages