Add methods needed for overflow panels to NativePanel interface.

chrome/browser/ui/panels/native_panel.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PANELS_NATIVE_PANEL_H_
 #define CHROME_BROWSER_UI_PANELS_NATIVE_PANEL_H_
 #pragma once
 
 #include "chrome/browser/ui/panels/panel.h"
 #include "ui/gfx/native_widget_types.h"
@@ skipping 14 matching lines @@
 // 2. We need some additional methods that BrowserWindow doesn't provide, such
 //    as MinimizePanel() and RestorePanel().
 // Note that even though we don't use BrowserWindow directly, Windows and GTK+
 // still use the BrowserWindow interface as part of their implementation so we
 // use Panel in all the method names to avoid collisions.
 class NativePanel {
   friend class Panel;
   friend class PanelBrowserTest;
 
  protected:
+  enum PanelIconState {
+    SHOW_ICON_IN_DESKTOP_BAR,
+    HIDE_ICON_IN_DESKTOP_BAR
+  };
+
   virtual ~NativePanel() {}
 
   virtual void ShowPanel() = 0;
   virtual void ShowPanelInactive() = 0;
   virtual gfx::Rect GetPanelBounds() const = 0;
   virtual void SetPanelBounds(const gfx::Rect& bounds) = 0;
   virtual void ClosePanel() = 0;
   virtual void ActivatePanel() = 0;
   virtual void DeactivatePanel() = 0;
   virtual bool IsPanelActive() const = 0;
@@ skipping 18 matching lines @@
   virtual void DestroyPanelBrowser() = 0;
 
   // Returns the exterior size of the panel window given the client content
   // size and vice versa.
   virtual gfx::Size WindowSizeFromContentSize(
       const gfx::Size& content_size) const = 0;
   virtual gfx::Size ContentSizeFromWindowSize(
       const gfx::Size& window_size) const = 0;
 
   virtual int TitleOnlyHeight() const = 0;
+
+  // Returns the size of the iconified panel. This is the size we use to draw
+  // the panel put in the overflow area.
+  virtual gfx::Size GetIconifiedPanelSize() const = 0;

[jennb, 2011/11/24 01:16:28]

Is this the size when not hovering on the overflow area? Can you describe the
flow for how the overflow logic will figure out the size for each panel? I had
thought the overflow strip would figure out the bounds and size for each panel
and then call SetPanelBounds().

[jianli, 2011/11/24 01:47:10]

This method only intends to return platform-specific size for iconified panel.
The OverflowStrip::Layout will use this size to figure out the bounds per mouse
hover over or not. I will put comment in the panel_overflow_strip.h that is
going to send out in another patch for review.

+
+  // Brings the panel to the top of the z-order without activating it. This
+  // will make sure that the panel is not obscured by other top-most windows.
+  virtual void EnsurePanelFullyVisible() = 0;
+
+  // Controls if the panel icon should appear in the taskbar or the dock.

[jennb, 2011/11/24 01:16:28]

Does this concept apply to Mac? If not, then just say "desktop bar" as that's
what the enum calls it.

[jianli, 2011/11/24 01:47:10]

Yes.

+  virtual void UpdatePanelIconInDesktopBar(PanelIconState state) = 0;
 };
 
 // A NativePanel utility interface used for accessing elements of the
 // native panel used only by test automation.
 class NativePanelTesting {
  public:
   static NativePanelTesting* Create(NativePanel* native_panel);
   virtual ~NativePanelTesting() {}
 
   virtual void PressLeftMouseButtonTitlebar(const gfx::Point& point) = 0;
   virtual void ReleaseMouseButtonTitlebar() = 0;
   virtual void DragTitlebar(int delta_x, int delta_y) = 0;
   virtual void CancelDragTitlebar() = 0;
   virtual void FinishDragTitlebar() = 0;
 
   // Verifies, on a deepest possible level, if the Panel is showing the "Draw
   // Attention" effects to the user. May include checking colors etc.
   virtual bool VerifyDrawingAttention() const = 0;
   // Verifies, on a deepest possible level, if the native panel is really
   // active, i.e. the titlebar is painted per its active state.
   virtual bool VerifyActiveState(bool is_active) = 0;
   virtual void WaitForWindowCreationToComplete() const { }
 
   virtual bool IsWindowSizeKnown() const = 0;
   virtual bool IsAnimatingBounds() const = 0;
 };
 
 #endif  // CHROME_BROWSER_UI_PANELS_NATIVE_PANEL_H_