Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 8681002: dbus: Fix a bug where we were emitting spurious error messages. (Closed)

Created:
9 years, 1 month ago by satorux1
Modified:
9 years, 1 month ago
Reviewers:
stevenjb
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

dbus: Fix a bug where we were emitting spurious error messages. Error messages like "Requested to remove an unknown match rule: type='signal', interface='...'" were emitted at shutdown of Bus object if an object proxy was connected to more than one signal of the same interface. TEST=changed the end_to_end_async_unittest to reproduce this bug, and confirm that the error messages were gone after fixing object_proxy.{cc,h} BUG=chromium-os:23382 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111423

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -13 lines) Patch
M dbus/end_to_end_async_unittest.cc View 1 3 chunks +20 lines, -1 line 0 comments Download
M dbus/object_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M dbus/object_proxy.cc View 2 chunks +20 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
satorux1
9 years, 1 month ago (2011-11-23 07:46:06 UTC) #1
stevenjb
lgtm with comment. http://codereview.chromium.org/8681002/diff/1/dbus/end_to_end_async_unittest.cc File dbus/end_to_end_async_unittest.cc (right): http://codereview.chromium.org/8681002/diff/1/dbus/end_to_end_async_unittest.cc#newcode139 dbus/end_to_end_async_unittest.cc:139: // Copy the string payload to ...
9 years, 1 month ago (2011-11-23 21:24:55 UTC) #2
satorux1
9 years, 1 month ago (2011-11-23 21:47:36 UTC) #3
http://codereview.chromium.org/8681002/diff/1/dbus/end_to_end_async_unittest.cc
File dbus/end_to_end_async_unittest.cc (right):

http://codereview.chromium.org/8681002/diff/1/dbus/end_to_end_async_unittest....
dbus/end_to_end_async_unittest.cc:139: // Copy the string payload to
|test_signal_string_|.
On 2011/11/23 21:24:55, Steven Bennetts wrote:
> Copy comment invalid.

Done.

Powered by Google App Engine
This is Rietveld 408576698