Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 8681001: Revert 111288 - Possibly broke media_unittests on Mac (Closed)

Created:
9 years ago by Ryan Sleevi
Modified:
9 years ago
Reviewers:
tfarina
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 111288 - Possibly broke media_unittests on Mac ui/gfx: Convert Canvas::DrawRectInt() to use gfx::Rect. BUG=100898 R=pkasting@chromium.org Review URL: http://codereview.chromium.org/8476019 TBR=tfarina@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111323

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -65 lines) Patch
M chrome/browser/ui/gtk/gtk_theme_service.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/app_panel_browser_frame_view.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/gfx/canvas.h View 1 chunk +7 lines, -5 lines 0 comments Download
M ui/gfx/canvas_skia.h View 1 chunk +7 lines, -5 lines 0 comments Download
M ui/gfx/canvas_skia.cc View 4 chunks +15 lines, -16 lines 0 comments Download
M ui/gfx/canvas_skia_win.cc View 2 chunks +3 lines, -5 lines 0 comments Download
MM ui/gfx/render_text.cc View 1 chunk +3 lines, -1 line 0 comments Download
MM ui/gfx/render_text_linux.cc View 1 chunk +6 lines, -1 line 0 comments Download
M ui/gfx/render_text_win.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/gfx/skia_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/skia_util.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/window/custom_frame_view.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ryan Sleevi
9 years ago (2011-11-23 06:39:45 UTC) #1
yosin_UTC9
On 2011/11/23 06:39:45, Ryan Sleevi wrote: ACK
9 years ago (2011-11-23 06:40:32 UTC) #2
yosin_UTC9
On 2011/11/23 06:40:32, Yoshifumi Inoue wrote: > On 2011/11/23 06:39:45, Ryan Sleevi wrote: > > ...
9 years ago (2011-11-23 06:41:21 UTC) #3
Ryan Sleevi
tfarina: You know I hate to revert - but trying to find out why the ...
9 years ago (2011-11-23 08:19:28 UTC) #4
tfarina
9 years ago (2011-11-23 16:31:49 UTC) #5
On Wed, Nov 23, 2011 at 6:19 AM,  <rsleevi@chromium.org> wrote:
> tfarina: You know I hate to revert - but trying to find out why the Mac 10.5
> and
> 10.6 bots started failing the media tests (http://crbug.com/105234)
>
> media depends on ui/, and your CL, of all those in the Window, touched ui/
> non-trivially, so I felt yours was the most likely candidate.
>
It is passing on media_unittests trybot on mac.

http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/4354/steps...

-- 
Thiago

Powered by Google App Engine
This is Rietveld 408576698