Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: chrome/browser/resources/ntp4/new_tab.js

Issue 8680033: Show GAIA profile info in NTP (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address review comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/ntp4/new_tab.js
diff --git a/chrome/browser/resources/ntp4/new_tab.js b/chrome/browser/resources/ntp4/new_tab.js
index 53f3a53022cdb132620cf63f1dc5837b6b2e8fac..134f426ab3e9e7885c365e9a5273808db1111c16 100644
--- a/chrome/browser/resources/ntp4/new_tab.js
+++ b/chrome/browser/resources/ntp4/new_tab.js
@@ -358,13 +358,24 @@ cr.define('ntp4', function() {
* the login container is hidden.
* @param {string} loginHeader The first line of text.
* @param {string} loginSubHeader The second line of text.
+ * @param {string} iconURL The url for the login status icon. If this is null
+ then the login status icon is hidden.
*/
- function updateLogin(loginHeader, loginSubHeader) {
+ function updateLogin(loginHeader, loginSubHeader, iconURL) {
if (loginHeader || loginSubHeader) {
$('login-container').hidden = false;
$('login-status-header').innerHTML = loginHeader;
$('login-status-sub-header').innerHTML = loginSubHeader;
$('card-slider-frame').classList.add('showing-login-area');
+
+ if (iconURL) {
+ $('login-status-header-container').style.backgroundImage = url(iconURL);
+ $('login-status-header-container').classList.add('login-status-icon');
+ } else {
+ $('login-status-header-container').style.backgroundImage = "none";
Evan Stade 2011/12/02 21:02:16 single quotes
sail 2011/12/03 00:09:00 Done.
+ $('login-status-header-container').classList.remove(
+ 'login-status-icon');
+ }
} else {
$('login-container').hidden = true;
$('card-slider-frame').classList.remove('showing-login-area');
@@ -373,6 +384,8 @@ cr.define('ntp4', function() {
window.setTimeout(loginBubble.show.bind(loginBubble), 0);
chrome.send('loginMessageSeen');
shouldShowLoginBubble = false;
+ } else if (loginBubble) {
+ loginBubble.reposition();
}
}

Powered by Google App Engine
This is Rietveld 408576698