Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8680024: Add return logic calling WebFrame. (Closed)

Created:
9 years, 1 month ago by Greg Billock
Modified:
9 years, 1 month ago
Reviewers:
jam, James Hawkins
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Add return logic calling WebFrame. R=jhawkins@chromium.org BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111475

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove flag check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M content/renderer/intents_dispatcher.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Greg Billock
9 years, 1 month ago (2011-11-23 21:13:36 UTC) #1
James Hawkins
http://codereview.chromium.org/8680024/diff/1/content/renderer/intents_dispatcher.cc File content/renderer/intents_dispatcher.cc (right): http://codereview.chromium.org/8680024/diff/1/content/renderer/intents_dispatcher.cc#newcode153 content/renderer/intents_dispatcher.cc:153: if (!CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnableWebIntents)) Eh, just leave this out. We'll enable ...
9 years, 1 month ago (2011-11-23 21:23:18 UTC) #2
Greg Billock
http://codereview.chromium.org/8680024/diff/1/content/renderer/intents_dispatcher.cc File content/renderer/intents_dispatcher.cc (right): http://codereview.chromium.org/8680024/diff/1/content/renderer/intents_dispatcher.cc#newcode153 content/renderer/intents_dispatcher.cc:153: if (!CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnableWebIntents)) On 2011/11/23 21:23:18, James Hawkins wrote: > ...
9 years, 1 month ago (2011-11-23 22:29:48 UTC) #3
Greg Billock
(+jam for content/) On 2011/11/23 22:29:48, Greg Billock wrote: > http://codereview.chromium.org/8680024/diff/1/content/renderer/intents_dispatcher.cc > File content/renderer/intents_dispatcher.cc (right): ...
9 years, 1 month ago (2011-11-23 22:30:18 UTC) #4
James Hawkins
LGTM
9 years, 1 month ago (2011-11-23 22:32:20 UTC) #5
jam
lgtm
9 years, 1 month ago (2011-11-24 00:03:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/8680024/4002
9 years, 1 month ago (2011-11-24 00:15:07 UTC) #7
commit-bot: I haz the power
9 years, 1 month ago (2011-11-24 01:51:50 UTC) #8 
Change committed as 111475

Powered by Google App Engine
This is Rietveld 408576698