Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8680018: Fix python scripts in src/chrome/ (Closed)

Created:
9 years, 1 month ago by M-A Ruel
Modified:
9 years ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, nkostylev+watch_chromium.org, John Grabowski, rginda+watch_chromium.org, native-client-reviews_googlegroups.com, Ilya Sherman, dhollowa, GeorgeY, ncarter (slow), stevenjb+watch_chromium.org, achuith+watch_chromium.org, darin-cc_chromium.org, dennis_jeffrey, tim (not reviewing), kkania, Raghu Simha, cbentzel+watch_chromium.org, arv (Not doing code reviews), pam+watch_chromium.org, akalin, Nirnimesh, anantha, dyu1, Paweł Hajdan Jr., davemoore+watch_chromium.org
Visibility:
Public.

Description

Fix python scripts in src/chrome/ Make sure that: - shebang is only present for executable files - shebang is #!/usr/bin/env python - __main__ is only present for executable files - file's executable bit is coherent Also fix EOF LF to be only one. Minor python style fixes. TBR=nirnimesh@chromium.org BUG=105108 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111658

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : Removed 2 files from chrome/test/chromeos/autotest/ #

Patch Set 4 : copyright #

Unified diffs Side-by-side diffs Delta from patch set Stats (+597 lines, -626 lines) Patch
M chrome/PRESUBMIT.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/policy/syntax_check_policy_template_json.py View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/PRESUBMIT.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/gen_ibus_input_methods.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/litify_proto_file.py View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/resources/file_manager/bin/squashdir.py View 4 chunks +11 lines, -3 lines 0 comments Download
M chrome/browser/sync/PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/PRESUBMIT.py View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/build_nacl_irt.py View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/common/net/PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/prebuild/create_string_rc.py View 6 chunks +12 lines, -6 lines 0 comments Download
M chrome/nacl/nacl_helper_bootstrap_munge_phdr.py View 2 chunks +19 lines, -16 lines 0 comments Download
M chrome/test/data/autofill/merge/tools/flatten.py View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/data/autofill/merge/tools/reserialize_profiles_from_query.py View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/data/autofill/merge/tools/serialize_profiles.py View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/test/nacl_test_injection/buildbot_nacl_integration.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/pyautolib/bookmark_model.py View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/test/pyautolib/chrome_driver_factory.py View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/pyautolib/chromeos/chromeos_utils.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/pyautolib/chromeos/enable_testing.py View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/pyautolib/chromeos/file_browser.py View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/pyautolib/chromeos/suid_actions.py View 1 5 chunks +4 lines, -5 lines 0 comments Download
M chrome/test/pyautolib/chromeos_network.py View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/pyautolib/chromoting.py View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/pyautolib/download_info.py View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/pyautolib/fetch_prebuilt_pyauto.py View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/pyautolib/generate_docs.py View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/pyautolib/history_info.py View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M chrome/test/pyautolib/omnibox_info.py View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/test/pyautolib/perf_snapshot.py View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/pyautolib/plugins_info.py View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/test/pyautolib/prefs_info.py View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/test/pyautolib/pyauto.py View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/pyautolib/pyauto_errors.py View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/test/pyautolib/pyauto_paths.py View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/pyautolib/pyauto_utils.py View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/pyautolib/pyauto_utils_test.py View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/test/pyautolib/remote_host.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/pyautolib/timer_queue.py View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/test/webdriver/test/chromedriver_factory.py View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/webdriver/test/chromedriver_launcher.py View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/webdriver/test/chromedriver_server.py View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/webdriver/test/chromedriver_test.py View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/webdriver/test/chromedriver_tests.py View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/webdriver/test/py_unittest_util.py View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/webdriver/test/run_chromedriver_tests.py View 4 chunks +9 lines, -5 lines 0 comments Download
M chrome/test/webdriver/test/run_webdriver_tests.py View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/webdriver/test/test_paths.py View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/webdriver/test/util.py View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/third_party/jstemplate/compile.py View 1 1 chunk +36 lines, -30 lines 0 comments Download
M chrome/tools/automated_ui_test_tools/ui_action_generator.py View 3 chunks +4 lines, -7 lines 0 comments Download
M chrome/tools/build/appid.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/build/generate_policy_source.py View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/tools/build/win/create_installer_archive.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/build/win/dependencies.py View 1 2 3 4 chunks +16 lines, -15 lines 0 comments Download
M chrome/tools/build/win/make_policy_zip.py View 5 chunks +5 lines, -1 line 0 comments Download
M chrome/tools/build/win/scan_server_dlls.py View 1 2 3 3 chunks +13 lines, -13 lines 0 comments Download
M chrome/tools/build/win/sln_deps.py View 1 2 3 4 chunks +9 lines, -5 lines 0 comments Download
D chrome/tools/build/win/sort_sln.py View 1 chunk +0 lines, -56 lines 0 comments Download
M chrome/tools/check_grd_for_unused_strings.py View 1 2 3 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/tools/extract_actions.py View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/tools/extract_histograms.py View 1 2 3 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/tools/history-viz.py View 7 chunks +99 lines, -87 lines 0 comments Download
M chrome/tools/inconsistent-eol.py View 1 2 3 6 chunks +13 lines, -5 lines 0 comments Download
M chrome/tools/process_dumps_linux.py View 3 chunks +8 lines, -6 lines 0 comments Download
M chrome/tools/webforms_aggregator.py View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/tools/webforms_aggregator_tests.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/webforms_aggregator_unittests.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/webforms_extractor.py View 1 chunk +253 lines, -253 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
Context: I'm going to add a presubmit check to enforce some of these rules.
9 years, 1 month ago (2011-11-23 19:43:24 UTC) #1
Nirnimesh
LGTM after you fix the one comment. Thanks for doing this. http://codereview.chromium.org/8680018/diff/2001/chrome/test/chromeos/autotest/files/client/deps/chrome_test/chrome_test.py File chrome/test/chromeos/autotest/files/client/deps/chrome_test/chrome_test.py (right): ...
9 years, 1 month ago (2011-11-23 21:42:25 UTC) #2
M-A Ruel
9 years, 1 month ago (2011-11-23 21:50:58 UTC) #3 
On 2011/11/23 21:42:25, Nirnimesh wrote:
> Please skip the files in chrome/test/chromeos/autotest/...

done

Powered by Google App Engine
This is Rietveld 408576698