Issue 8680016: A few more base::Bind migrations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8680016: A few more base::Bind migrations. (Closed)

Created:
9 years, 1 month ago by csilv

Modified:
9 years, 1 month ago

Reviewers:
James Hawkins

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., jam, dpranke-watch+content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

A few more base::Bind migrations. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111484

Patch Set 4 : win compile fix #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -22 lines)			Patch
M	chrome/browser/enumerate_modules_model_win.cc	View	1 2	3 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/external_tab_container_win.h	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/external_tab_container_win.cc	View	1 2 3	5 chunks	+11 lines, -9 lines	0 comments	Download
M	content/browser/idbbindingutilities_browsertest.cc	View	1 2	5 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

LGTM with nit. http://codereview.chromium.org/8680016/diff/5001/chrome/browser/external_tab_container_win.cc File chrome/browser/external_tab_container_win.cc (right): http://codereview.chromium.org/8680016/diff/5001/chrome/browser/external_tab_container_win.cc#newcode106 chrome/browser/external_tab_container_win.cc:106: weak_factory_(this), ALLOW_THIS_... for consistency across the ...

9 years, 1 month ago (2011-11-23 18:09:51 UTC) #2

csilv

9 years, 1 month ago (2011-11-23 18:35:36 UTC) #3

http://codereview.chromium.org/8680016/diff/5001/chrome/browser/external_tab_...
File chrome/browser/external_tab_container_win.cc (right):

http://codereview.chromium.org/8680016/diff/5001/chrome/browser/external_tab_...
chrome/browser/external_tab_container_win.cc:106: weak_factory_(this),
On 2011/11/23 18:09:51, James Hawkins wrote:
> ALLOW_THIS_... for consistency across the code base.

Done.

Expand Messages | Collapse Messages

Issue 8680016: A few more base::Bind migrations. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : win compile fix #

Messages