Issue 8680015: base::Bind: Convert view_http_cache_job_factory.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8680015: base::Bind: Convert view_http_cache_job_factory.cc. (Closed)

Created:
9 years, 1 month ago by James Hawkins

Modified:
9 years, 1 month ago

Reviewers:
csilv

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

base::Bind: Convert view_http_cache_job_factory.cc. Had to convert ViewCacheHelper at the same time. BUG=none TEST=none R=csilv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111409

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -53 lines)			Patch
M	chrome/browser/net/view_http_cache_job_factory.cc	View	10 chunks	+35 lines, -29 lines	1 comment	Download
M	net/url_request/view_cache_helper.h	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	net/url_request/view_cache_helper.cc	View	4 chunks	+8 lines, -10 lines	0 comments	Download
M	net/url_request/view_cache_helper_unittest.cc	View	5 chunks	+11 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

csilv

http://codereview.chromium.org/8680015/diff/1/chrome/browser/net/view_http_cache_job_factory.cc File chrome/browser/net/view_http_cache_job_factory.cc (left): http://codereview.chromium.org/8680015/diff/1/chrome/browser/net/view_http_cache_job_factory.cc#oldcode49 chrome/browser/net/view_http_cache_job_factory.cc:49: callback_(this, &Core::OnIOComplete)), I'm a little unclear what this old ...

9 years, 1 month ago (2011-11-23 18:37:32 UTC) #2

lgtm

Expand Messages | Collapse Messages