Add external strings support to regexp in generated code.

Add external strings support to regexp in generated code.

TEST=test/mjsunit/string-external-cached.js

Committed: http://code.google.com/p/v8/source/detail?r=10070

[Yang, 2011-11-23 15:19:10]

Please take a look.

This replaces http://codereview.chromium.org/8584003/

[Lasse Reichstein, 2011-11-25 12:56:50]

LGTM

http://codereview.chromium.org/8680010/diff/3001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/8680010/diff/3001/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:4563: __ and_(r1, r0, Operand(kIsNotStringMask |
kStringRepresentationMask), SetCC);
Could you add kShortStringMask here?
That would make r1 have the 0x10 bit set if it's short, just as it has the 0x80
bit set if it's not a string.
Any value above kStringRepresentationMask would make it go to runtime (with the
test for being not-a-string that was introduced here?)

http://codereview.chromium.org/8680010/diff/3001/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:4581: 
This was where you added the is-not-string test, right?

[Yang, 2011-11-25 14:19:25]

Landed.

http://codereview.chromium.org/8680010/diff/3001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/8680010/diff/3001/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:4563: __ and_(r1, r0, Operand(kIsNotStringMask |
kStringRepresentationMask), SetCC);
On 2011/11/25 12:56:50, Lasse Reichstein wrote:
> Could you add kShortStringMask here?
> That would make r1 have the 0x10 bit set if it's short, just as it has the
0x80
> bit set if it's not a string.
> Any value above kStringRepresentationMask would make it go to runtime (with
the
> test for being not-a-string that was introduced here?)

Great idea!