Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 8680003: Clean-up: Change chrome/browser's CSS time units from s to ms. (Closed)

Created:
9 years, 1 month ago by Dan Beam
Modified:
9 years, 1 month ago
CC:
chromium-reviews, asanka, nkostylev+watch_chromium.org, Erik does not do reviews, achuith+watch_chromium.org, Randy Smith (Not in Mondays), mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), estade+watch_chromium.org
Visibility:
Public.

Description

Clean-up: Change chrome/browser's CSS time units from s to ms if >= 1s duration (according to new web dev style guidance). R=estade@chromium.org,jhawkins@chromium.org BUG=None TEST=Nothing WebUI acts differently, everything's easier to read. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111450

Patch Set 1 #

Total comments: 2

Patch Set 2 : changing 0m?s -> 0 like style guide says, ☺ #

Patch Set 3 : if >= 1000ms, 1s #

Patch Set 4 : reverting change to 1.8s -> 1800ms in print_preview.css #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -91 lines) Patch
M chrome/browser/resources/active_downloads.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.css View 7 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/resources/chromeos/login/user_pod_row.css View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/file_manager/css/file_manager.css View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/file_manager/js/image_editor/gallery.css View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/file_manager/mediaplayer.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/new_tab.css View 1 2 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/ntp4/apps_page.css View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/ntp4/bookmarks_page.css View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/ntp4/most_visited_page.css View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/ntp4/nav_dot.css View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.css View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/ntp4/recently_closed.css View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/ntp4/tile_page.css View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/chromeos/system_options_page.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/extension_settings.css View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/handler_options.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/language_options.css View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/manage_profile_overlay.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/options_page.css View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/plugins.css View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.css View 3 3 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/resources/shared/css/dialogs.css View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/sync_promo.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/sync_setup_overlay.css View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Dan Beam
I used: egrep -Rn ' ([0-9]+|[0-9]+\.[0-9]+|\.[0-9])s[^t]' --include=*.html --include=*.css --include=*.js chrome/browser/resources/ | grep -v Guido | ...
9 years, 1 month ago (2011-11-23 06:29:09 UTC) #1
Evan Stade
+jhawkins lgtm, can you also add a rule to the style guide http://codereview.chromium.org/8680003/diff/1/chrome/browser/resources/sync_setup_overlay.css File chrome/browser/resources/sync_setup_overlay.css ...
9 years, 1 month ago (2011-11-23 06:31:42 UTC) #2
Dan Beam
http://codereview.chromium.org/8680003/diff/1/chrome/browser/resources/sync_setup_overlay.css File chrome/browser/resources/sync_setup_overlay.css (right): http://codereview.chromium.org/8680003/diff/1/chrome/browser/resources/sync_setup_overlay.css#newcode181 chrome/browser/resources/sync_setup_overlay.css:181: -webkit-transition: margin-top 330ms ease-out, opacity 660ms ease-out; On 2011/11/23 ...
9 years, 1 month ago (2011-11-23 06:33:54 UTC) #3
Dan Beam
> lgtm, can you also add a rule to the style guide Done.
9 years, 1 month ago (2011-11-23 06:42:00 UTC) #4
Dan Beam
9 years, 1 month ago (2011-11-23 16:28:35 UTC) #5
James Hawkins
LGTM
9 years, 1 month ago (2011-11-23 16:36:11 UTC) #6
Dan Beam
* wonders how many merge conflicts this will cause
9 years, 1 month ago (2011-11-23 16:37:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/8680003/4007
9 years, 1 month ago (2011-11-23 22:46:07 UTC) #8
commit-bot: I haz the power
9 years, 1 month ago (2011-11-23 23:55:58 UTC) #9
Change committed as 111450

Powered by Google App Engine
This is Rietveld 408576698