Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 8679023: Add about:flags for enabling gamepad. (Closed)

Created:
9 years, 1 month ago by scottmg
Modified:
9 years ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add about:flags entry for enabling gamepad. BUG=79050 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111562

Patch Set 1 #

Patch Set 2 : fix capitalization on name, and improve description #

Total comments: 2

Patch Set 3 : remove unneeded sentence #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
9 years, 1 month ago (2011-11-24 02:19:30 UTC) #1
Nico
lgtm http://codereview.chromium.org/8679023/diff/3001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/8679023/diff/3001/chrome/app/generated_resources.grd#newcode4890 chrome/app/generated_resources.grd:4890: <message name="IDS_FLAGS_ENABLE_GAMEPAD_DESCRIPTION" desc="Description for the flag to enable ...
9 years ago (2011-11-24 22:06:41 UTC) #2
scottmg
On 2011/11/24 22:06:41, Nico wrote: > lgtm > > http://codereview.chromium.org/8679023/diff/3001/chrome/app/generated_resources.grd > File chrome/app/generated_resources.grd (right): > ...
9 years ago (2011-11-24 22:13:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/8679023/7001
9 years ago (2011-11-24 22:13:38 UTC) #4
commit-bot: I haz the power
9 years ago (2011-11-24 23:20:53 UTC) #5
Change committed as 111562

Powered by Google App Engine
This is Rietveld 408576698