Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: remoting/webapp/me2mom/host_list.js

Issue 8679017: Don't update jabberId when renaming a host. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/me2mom/host_list.js
diff --git a/remoting/webapp/me2mom/host_list.js b/remoting/webapp/me2mom/host_list.js
index 8fd59c0cf9a1f66d12e7c437174382b67bda7633..3e3126b5802c563e07c7f4e576f7cbfdd76c8734 100644
--- a/remoting/webapp/me2mom/host_list.js
+++ b/remoting/webapp/me2mom/host_list.js
@@ -122,8 +122,7 @@ remoting.HostList.prototype.setHosts_ = function(hosts) {
/** @type {remoting.Host} */
var host = hosts[i];
// Validate the entry to make sure it has all the fields we expect.
- if (host.hostName && host.hostId && host.status && host.jabberId &&
Jamie 2011/11/23 20:53:23 I think we still need to check for jabberId. The p
Sergey Ulanov 2011/11/23 21:10:47 JabberId may not be set if the host was registered
Sergey Ulanov 2011/11/23 21:16:50 Reverted this change for now. Will address in a se
- host.publicKey) {
+ if (host.hostName && host.hostId && host.status && host.publicKey) {
var onRename = function() { that.renameHost_(host.hostId); }
var onDelete = function() { that.deleteHost_(host.hostId); }
var hostTableEntry = new remoting.HostTableEntry();
@@ -221,7 +220,11 @@ remoting.HostList.prototype.renameHost_ = function(hostId) {
'Authorization': 'OAuth ' + token,
'Content-type' : 'application/json; charset=UTF-8'
};
- var newHostDetails = { data: hostTableEntry.host };
+ var newHostDetails = { data: {
+ hostId: hostTableEntry.host.hostId,
+ hostName: hostTableEntry.host.hostName,
+ publicKey: hostTableEntry.host.publicKey
+ } };
remoting.xhr.put(
'https://www.googleapis.com/chromoting/v1/@me/hosts/' + hostId,
function(xhr) {},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698