Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 8679015: Add OVERRIDE to chrome/. (Closed)

Created:
9 years ago by Avi (use Gerrit)
Modified:
9 years ago
Reviewers:
Elliot Glaysher, Jói
CC:
chromium-reviews, creis+watch_chromium.org, fischman+watch_chromium.org, Erik does not do reviews, ajwong+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, pam+watch_chromium.org, ukai+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Add OVERRIDE to chrome/. BUG=104314 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111757

Patch Set 1 #

Patch Set 2 : update #

Total comments: 1

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -40 lines) Patch
M chrome/browser/crash_handler_host_linux.h View 7 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_info_private_api_chromeos.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_input_ui_api.h View 3 chunks +19 lines, -14 lines 0 comments Download
M chrome/browser/geolocation/wifi_data_provider_chromeos.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/image_decoder.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/oom_priority_manager.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/screensaver_window_finder_gtk.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_gtk.h View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/themes/theme_service.h View 2 chunks +14 lines, -6 lines 0 comments Download
M chrome/browser/ui/input_window_dialog_gtk.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
Please review carefully the theme service where the change isn't just boilerplate. http://codereview.chromium.org/8679015/diff/1001/chrome/browser/themes/theme_service.h File chrome/browser/themes/theme_service.h ...
9 years ago (2011-11-23 19:38:28 UTC) #1
Avi (use Gerrit)
Jói's available.
9 years ago (2011-11-28 17:54:22 UTC) #2
Elliot Glaysher
I understand you don't want to change the semantics so lgtm.
9 years ago (2011-11-28 18:09:37 UTC) #3
Avi (use Gerrit)
9 years ago (2011-11-28 18:56:03 UTC) #4
On 2011/11/28 18:09:37, Elliot Glaysher wrote:
> I understand you don't want to change the semantics so lgtm.

Right. That's why I filed a bug, so that someone who knows more about how things
work can go in there and clean it up.

Powered by Google App Engine
This is Rietveld 408576698