Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2494)

Unified Diff: chrome_frame/test/net/fake_external_tab.cc

Issue 8679012: Disabling chrome frame net tests on IE9 as they are flaky. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/net/fake_external_tab.cc
===================================================================
--- chrome_frame/test/net/fake_external_tab.cc (revision 109912)
+++ chrome_frame/test/net/fake_external_tab.cc (working copy)
@@ -587,6 +587,16 @@
}
int main(int argc, char** argv) {
+ if (chrome_frame_test::GetInstalledIEVersion() >= IE_9) {
+ // Adding this here as the command line and the logging stuff gets
+ // initialized in the NetTestSuite constructor. Did not want to break that.
+ base::AtExitManager at_exit_manager;
+ CommandLine::Init(argc, argv);
+ CFUrlRequestUnittestRunner::InitializeLogging();
+ LOG(INFO) << "Not running ChromeFrame net tests on IE9+";
+ return 0;
+ }
+
google_breakpad::scoped_ptr<google_breakpad::ExceptionHandler> breakpad(
InitializeCrashReporting(HEADLESS));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698